Rottenbeer / ItemRack

ItemRack working for WoW Classic
41 stars 45 forks source link

SOD a bazillion errors #271

Closed nwardoh closed 2 months ago

nwardoh commented 2 months ago

When clicking the minimap button the errors just start scrolling non-stop.

image

Tegas commented 2 months ago

The GetMouseFocus function has been replaced by GetMouseFoci.

https://warcraft.wiki.gg/wiki/Patch_11.0.0/API_changes

I got it working by swapping local frame = GetMouseFocus() to local frame = GetMouseFoci()[1]

Tegas commented 2 months ago

It seems there's already a PR with a better fix. https://github.com/Rottenbeer/ItemRack/pull/270/commits/fe393625d77df777115171f6c05c1374f2f8cc5c

konffen commented 2 months ago

Managed to copypaste the error from BugSack:

4442x ItemRack/ItemRack.lua:1289: attempt to call global 'GetMouseFocus' (a nil value)
[string "@ItemRack/ItemRack.lua"]:1289: in function `func'
[string "@ItemRack/ItemRack.lua"]:1016: in function `OnUpdate'
[string "*ItemRack.xml:7_OnUpdate"]:1: in function <[string "*ItemRack.xml:7_OnUpdate"]:1>

Locals:
(*temporary) = nil
(*temporary) = "attempt to call global 'GetMouseFocus' (a nil value)"
nwardoh commented 2 months ago

What's the plan here? This game is basically unplayable as a tank without this addon

mikinho commented 2 months ago

Have a fix made https://github.com/Rottenbeer/ItemRack/pull/270

Can provide a zip for those who need it until it is merged

Rottenbeer commented 2 months ago

Released as 4.11