Rottenbeer / ItemRack

ItemRack working for WoW Classic
41 stars 45 forks source link

Hotswap Weakaura and Itemrack no longer work (Classic Era 1.15.4) #275

Closed maximus210793 closed 2 months ago

maximus210793 commented 2 months ago

Hi, Warrior Hotswap (https://wago.io/djN0VftGP/3) does not longer work since version update. Chat Message with newest Version says: "ItemRack: Swap stopped. Something is on the cursor."

I am playing WoW Classic Era V1.15.4. See also: https://github.com/Rottenbeer/ItemRack/issues/254

Thank you for fixing it.

Rottenbeer commented 2 months ago

Which ItemRack version did you test?

Rottenbeer commented 2 months ago

Try 4.2

maximus210793 commented 2 months ago

both 4.2 and 4.21 are not working, they also miss this change in the ItemRackEquip.lua: Change Line 283 in "ItemRackEquip.lua" from 283: if swap[k]==0 then -- if intended to be empty to 283: if swap[k]==0 or swap[k]=="0" then -- if intended to be empty

Rottenbeer commented 2 months ago

Can you make an PR please?

maximus210793 commented 2 months ago

what is PR release?

Rottenbeer commented 2 months ago

A PR is a pull request here on github. I merge and release it afterwards.

maximus210793 commented 2 months ago

I have no clue what to do sry :( I only know that the solution from https://github.com/Rottenbeer/ItemRack/issues/254 worked: Change Line 283 in "ItemRackEquip.lua" from 283: if swap[k]==0 then -- if intended to be empty to 283: if swap[k]==0 or swap[k]=="0" then -- if intended to be empty

maximus210793 commented 2 months ago

Update: Version 4.21 now working for me. But in the ItemRackEquip.lua it says in line 283: if swap[k]==0 then -- if intended to be empty Did you fix it somewhere else in the code since it is not saying: 283: if swap[k]==0 or swap[k]=="0" then -- if intended to be empty ?

Rottenbeer commented 2 months ago

The PR had two different solutions and fixed it somewhere else. See https://github.com/Rottenbeer/ItemRack/pull/259

maximus210793 commented 2 months ago

Still having problems with changing gear sets, when one has a shirt equipped and the other one not. Producing a "Swap stopped. Something is on the cursor" error. Even with changing line 283 to if swap[k]==0 or swap[k]=="0" then -- if intended to be empty