Rotwood-Vale / Ratwood-Keep

Ratwood | Anthro-Allowed Medieval Roleplay
https://wiki.ratwood.rip/
GNU Affero General Public License v3.0
24 stars 314 forks source link

Stamina and Fatigue are swapped. #1063

Closed burdwatcher closed 3 weeks ago

burdwatcher commented 1 month ago

Stamina and Fatigue bars are swapped, thus leading people who are coding to select the wrong variable. For instance athletics is coded so that levels in it only raise your blue bar and do nothing for your green because they're coded to change rogstam which is actually fatigue as shown below:

See UI names being swapped:

/atom/movable/screen/rogfat
    name = "stamina"
    icon_state = "fat100"
    icon = 'icons/mob/rogueheat.dmi'
    screen_loc = rogueui_fat

/atom/movable/screen/rogstam
    name = "fatigue"
    icon_state = "stam100"
    icon = 'icons/mob/rogueheat.dmi'
    screen_loc = rogueui_fat

See athletics code:

/mob/living/proc/update_rogstam()
    var/athletics_skill = 0
    if(mind)
        athletics_skill = mind.get_skill_level(/datum/skill/misc/athletics)
    maxrogstam = (STAEND + (athletics_skill/2 ) ) * 100
    if(cmode)
        if(!HAS_TRAIT(src, TRAIT_BREADY))
            rogstam_add(-2)

Pretty sure athletics should be raising your green bar, not your blue bar. I don't think any physical role actually cares terribly much about the blue bar, it does affect physical roles slightly with swift intent and such but not nearly as much as having extra green would aid. Right now raising athletics helps mages far more than it does non-magic users.

katsukai commented 1 month ago

this is really hilarious

Nakalon commented 4 weeks ago

I'm having a look at this but im terribly confused.

As I see it, if the names were INDEED swapped then Fatigue would be the green bad and Stamina de blue bar.

However that does not make sense, because the blue bar is the one that can only be regained by sleeping. Which makes more sense if its called Fatigue.

HOWEVER, all instances in code call it "rogstam" instead thus leading to this confusion.

The only proper solution I see is... renaming EVERYTHING. The only thing thats in the rigth place is the bloody name of the thing!

Nakalon commented 4 weeks ago

turns out, unless im terribly wrong this is just a UI issue, and its easy to fix

Nakalon commented 4 weeks ago

Nevermind, I had a terrible brainfart... I think the blue bar is supposed to be called stamina and the green bar fatigue...