search

Rotwood-Vale / Ratwood-Keep

GNU Affero General Public License v3.0
13 stars 85 forks source link

CROWN SUMMONING FIXES | Makes you no longer need to wear any hat to use throne basic commands. #180

Closed Yawet330 closed 4 days ago

Yawet330 commented 1 week ago

About The Pull Request

Zethcode.

Why It's Good For The Game

Zethcode being fixed is always good. Right now, if you are not wearing something on your head slot, you cannot use the throne regardless, even Summon Crown.

This removes that, and changes how the Crown works.

Should the Crown not be present on a living human, it may immediately be summoned back to the keep (like before), though with a visible message instead.

This means that unlike before if the King was decapitated and the crown hidden, or thrown into the acid pit, there is now an actual way to retrieve the crown. image

Azarak commented 1 week ago

Why use signals for this if it's a specific case on one item that you already have a reference to?

Gyrandola commented 1 week ago

Can you be more clear on which "throne basic commands" you are talking about, other than summon crown?

Yawet330 commented 1 week ago

Can you be more clear on which "throne basic commands" you are talking about, other than summon crown?

All commands except "Announce" And Summon Crown are advanced commands and require both the Crown and Coronation. This just fixes people being unable to make announcements as King once the Crown has been stolen (which was originally intended but... Zethcode).

Why use signals for this if it's a specific case on one item that you already have a reference to?

It was originally a far more complex system until I decided against it due to powergame concerns. Previously it would have worked even if the Crown were on a mob, should they not have moved, interacted with it, moved the Crown, equipped or unequipped it, etc. Just a legacy remnant of the stale system, versus the far more lightweight version it uses now.