Rotwood-Vale / Ratwood-Keep

GNU Affero General Public License v3.0
22 stars 257 forks source link

Accents 1.7th Edition #315

Closed Squird5 closed 1 month ago

Squird5 commented 3 months ago

About The Pull Request

A little more accent variety among races to make them less homogeneous ((I hated 100% of elves being Russian)). Also tried to make the formatting more consistent between the JSONs.

Also removed the majority of the non-English words from most lists (Except German), making them more oriented around the sounds they make than simply tossing in foreign words.

Why It's Good For The Game

More variety in speech patterns is always good. Also, all elves speaking demi-Russian would throw me completely out of character every time I saw "Privyet" or "Da" and I would stop thinking of my own character and instead of my friend's Pathfinder character.

REFERENCE GUIDE

Accents are now broken into four parts: Full, Start, End, and Syllable.

Full replaces only entire key words with their counterpart. Any additional characters will prevent it from triggering. "watch": "look" will only apply to "Watch", changing it to "Look", but variants like "Watched" or "Watches" will not change

Start will replace words that start with the key word, regardless of the following characters. "watch": "look" will end up allowing Watching and Watched to convert to Looking and Looked

End is the opposite of Start. It will apply to characters only at the end of a word. Useful for consistently dropping a letter at the end that would be messy if applied as a Syllable. "ing": "en'" will end up allowing Watching and Slapping to convert to Watchen' and Slappen'

Syllable will apply to any instance of the characters in the text, so use it carefully. "a": "aye" would end up being painful, changing "Have a nice day" to "Hayeve aye nice dayey"

Notes

Do not use escape characters for things like apostrophes. \' It will work in some cases, but not all, resulting in demihuman accents working fine while the exact same accent list on Humans doesn't.

The order of your replacers matters. While having them in alphabetical order might look nice, it can result in unwanted outcomes. If a "c" becomes a "k", and a "k" becomes "kh", words like "Change" turn into "Khhange".

Always test your work.

Change List

Images

Come, Nerevar. Friend or traitor, come. Come and look upon the Heart, and Akulakhan. Come to the Heart Chamber. I wait for you there, where we last met, countless ages ago.

  • Italian Ratwood_Italian
Squird5 commented 3 months ago

This does kind of undo #236, but in a way that is likely passable. Rather than just throwing around Spanish words, it's more hissing Ss and rolling Rs.

Gyrandola commented 3 months ago

good stuff

Plutolover99 commented 2 months ago

Could you also add that Half-Kins get the accent that they are ancestral to?

So a Grenzelhoft Half-Kin gets a German Accent, like all Grenzelhofts?

DorfGuy1 commented 2 months ago

Could you also add that Half-Kins get the accent that they are ancestral to?

So a Grenzelhoft Half-Kin gets a German Accent, like all Grenzelhofts?

I support this. Qualifications: None. I'm a player that knows how to read shitty byond code and thats it.

Squird5 commented 2 months ago

I have been off and on trying to add a method to pull a list of accents per race, then select them on the character creation screen, but I don't know enough of any of this to quite pull that off.

Suggestions on how to make that work would be appreciated, otherwise I will just fall back on accents being tied back to skintone.

Squird5 commented 2 months ago

Could you also add that Half-Kins get the accent that they are ancestral to?

So a Grenzelhoft Half-Kin gets a German Accent, like all Grenzelhofts?

This was added in Mod 1, a day before you asked

Squird5 commented 2 months ago

Went ahead and commented out the changes trying to add in the accent selection system and reenabled the skin_tone based accent system that was already in place, with the expansions and tweaks I added.

Azarak commented 2 months ago

The diffs are weird here, merge upstream/main into this

Squird5 commented 2 months ago

The diffs are weird here, merge upstream/main into this

Nuked the local repo, used commit history to remake it. Should have that fuckery fixed now.

CalamaBanana commented 2 months ago

Not the biggest fan of watering down racial identity even more, but please do keep the Russian elf accent on a pale skin at least as well. Timberborn is a very dark skin tone nearly no one uses. 99% of current elf chars are pale, and most of them are used to speaking the Russian accent by now. Please do add it to the Azuregrove skintone as well at least.

Squird5 commented 2 months ago

Reformatted to adhere to the new Regex rules as per #546

Tested on local, now fully working.

Squird5 commented 2 months ago

Added change list, pictures, reference guide Removed the kh from Russian and Tabaxi

Azarak commented 1 month ago

Feel free to make a new PR modifying the existing accents, adding / changing the accents of species and ancestries should be in subsequent, atomized PR's