search

Rotwood-Vale / Ratwood-Keep

GNU Affero General Public License v3.0
13 stars 89 forks source link

Fixes female variant armor overlay #321

Closed Azarak closed 2 days ago

Azarak commented 3 days ago

About The Pull Request

I introduced it by accident while cleaning up the code around here Fixes https://github.com/Rotwood-Vale/Ratwood-Keep/issues/303 Fixes https://github.com/Rotwood-Vale/Ratwood-Keep/issues/307

Why It's Good For The Game

aberrantQuesrist commented 2 days ago

Screenshot 2024-07-05 235141 Seems to have introduced a new bug in the side view of torn sleeves. The arms layer under the clothing.

Azarak commented 2 days ago

Screenshot 2024-07-05 235141 Seems to have introduced a new bug in the side view of torn sleeves. The arms layer under the clothing.

Can you explain how it was used to be? The layer ordering in the defines file would imply that this is the correct behaviour, with sleeves rendering over the body and over the armor

aberrantQuesrist commented 2 days ago

Used to render the bare arm over the dress. This renders the dress over the arm. It looks very weird, especially shifting from side view to front view.

Azarak commented 2 days ago

Used to render the bare arm over the dress. This renders the dress over the arm. It looks very weird, especially shifting from side view to front view.

In https://github.com/Rotwood-Vale/Ratwood-Keep/pull/311 I fixed an oddity where the "hand" sprites in west/east states would also include the arm, because this was problematic for body markings.

I think that's what's causing this current problem now, I'll have to make a solution which works for both features