Add support for PNM - Githubissues

Roughsketch / imagesize

Quickly probe the size of various image formats without reading the entire file.

MIT License

57 stars 12 forks source link

Add support for PNM #29

Closed Roughsketch closed 1 year ago

Roughsketch commented 1 year ago

This is still a work in progress. Most of it works, but there is a case in a P6 file where there are no newlines which breaks the parsing since I wrote it assuming that things would always be broken by newlines.

I do have open questions for this for anyone who cares (@akonneker?)

Should the ImageType be:
- Pnm
- Pnm(subtype)
- Split them into Pbm, Pgm, Ppm
- Something else?
Should I handle more than P1 - P6, and if so do you have example files? I've seen P7, PF, PF4, and there are probably more I'm not aware of.

Resolves #14

Roughsketch commented 1 year ago

Going to merge this as-is since it passes all the tests for the files I have now.

I have chosen to keep Pnm as its own value but I am still open to changing it later down the road if needed.