Changed error type to avoid creating strings

Roughsketch / imagesize

Quickly probe the size of various image formats without reading the entire file.

MIT License

57 stars 12 forks source link

Changed error type to avoid creating strings #7

Closed katyo closed 5 years ago

katyo commented 5 years ago

I changed error type (ImageError) due to next reasons:

To avoid creating string objects
To get compatibility with std::error

I added implementations for std::fmt::Display and std::error::Error. I removed String parameter from error enum variants.

Roughsketch commented 5 years ago

I'm going to merge this, but I'm going to hold back on publishing the crate immediately in case other changes come in. I want to avoid rapidly changing minor versions due to breaking changes.

Thanks again.

katyo commented 5 years ago