Added configuration for Docker

MuratovAS commented 2 years ago

I added the ability to deploy a container with your application. How to work with it is written in the readme

I checked the work on arm64 and amd64, I think there will be no problems on other platforms. Thanks to self-assembly of the container

Rouji commented 2 years ago

Hi! I'd like to keep this repository's contents as KISS and true to its name as possible. There is another repository with a PoC docker config here, and I'm thinking I'd like to keep it separate in the future as well. I'd wouldn't mind PRs against that repo though. It could really do with some more effort put into it :upside_down_face:

I have a few comments anyway:

CGI is a performance concern
There is no accounting for different configuration values as far as I can make out(?) People will want to set those. And setting upload_max_filesize to a fixed 2048M etc. is kind of bad.
Lots and lots of unnecessary stuff in php.ini in general
apk add stuff could be consolidated to one RUN
Not sure what php-dom is for, and considering config values should be changeable, the "fileinfo" module would be a good thing to have.
What's up with the values for static-file.exclude-extensions and index-file.names?

MuratovAS commented 2 years ago

You understood. I did not know that there is already a container implementation :) I think you need to add a link to the Docker configuration.

Your recommendations were useful to me. Thank you. If possible, corrected flaws. I think my configuration has the right to existence, it is a bit more compact. So it can be found in my repository.

Rouji commented 2 years ago

Feel free to contribute to my docker repository. It's not yet mentioned in the readme, because it's a PoC I threw together in like 1 afternoon and I don't use docker to host this myself. If it got a bit more mature(?), I'd link it.

Btw. getting rid of the php config and using sed instead is a good call, but you're still hard-coding config values. I get around that by using a shell script as an entry point: https://github.com/Rouji/single_php_filehost_docker/blob/master/entry.sh

Rouji / single_php_filehost

Added configuration for Docker #12