search

Rouji / single_php_filehost

Simple Filehosting Page in a Single PHP File (obvious 0x0 clone)
ISC License
235 stars 35 forks source link

Add exif stripping #30

Closed csprr closed 3 weeks ago

csprr commented 4 weeks ago

Not sure if this is something that is wanted or if it should be implemented, but this works for me.

One problem with this however is that when I upload using HUPL, the rotation does not work, in case it is rotated.

Rouji commented 3 weeks ago

This messes with user expectation... Having your files silently changed under your nose (even quality degraded if you're unlucky) isn't very nice. What if you want to keep your exif data? Those operations should be a user choice imo, but at that point they're just as well/better served at the client side. It's also a security/DoS concern. You could also already do it with an $EXTERNAL_HOOK

Re Hupl: is that something that's going wrong in the app?

csprr commented 3 weeks ago

That makes sense indeed. An external hook would be very useful in that regard I'd say.

I'm not sure if it's Hupl doing an odd thing or the upload in this way. I assume it has something to do with the image resize option in Hupl, but I can't confirm that.

Either way, with an external hook it shouldn't be an issue as that would handle the processed image while on the server already in either case.

Rouji commented 3 weeks ago

Yeah, I'm thinking I probably don't want that in my master right now. Thanks a lot for sharing though! At the very very least it's a searchable thing now, in case someone else needs it. And I think it's also a perfectly cromulent solution to just keep it in your fork(?)

Would you mind opening an issue on the Hupl repo for the Hupl thing?