Bug 7.0.0 - Bug findings

deuxge commented 10 months ago

Describe the bug None I hope

Additional context This thread is to list some findings with the new version. I moved the files from JS to TypeScript. There is more automated check on the function/variables. This should reduce bugs in the future. This will helps as well for unit testing (which I do not succed yet to make it working...) This is bit in the idea of #158. This helped me already to remove some bugs

In case of fallback, you can use this link to 6.18.5.

Change logs:

Move from JS to TypeScript
Update to make it building: -- Add some types to variables -- Change document.getElementById to jquery way to avoid null checks
Fix wrong finish detection of POA
Fix small bug when no floor can be detected on labyrinth Remove unsued variable on league, potential fix
Small fix on power place precision (when need more than 1M power)
Fix bug on troll battle when not enough energy
comment some unused function
start migrating deprecated click() from jquery to trigger('click')
Fix girl reward detection after game update
Refactory Event parsing to avoid code duplication
Fix a bug in market shopping
Refactory Pop girl selection into smaller function

The only change is the collect all in DP event #1055.

OldRon1977 commented 10 months ago

Looks promising 😁 I will start testing with HH, CH and PH as soon as possible. Thanks for the new version!

deuxge commented 10 months ago

I also finally succeed to have the new release visible on https://github.com/Roukys/HHauto/releases So you can found 7.0 and 6.18.5

I-I-I-I-I-I-I-I-I-I-I-I-I-I commented 10 months ago

I am getting

Uncaught TypeError: Cannot set properties of undefined (setting '0')
    at Troll.getTrollWithGirls (userscript.html?name=HaremHeroes-Automatic%252B%252B.user.js&id=1d7e9e71-0b99-4ac9-aa3c-42cacaf20c44:4647:48)
    at Troll.getTrollIdToFight (userscript.html?name=HaremHeroes-Automatic%252B%252B.user.js&id=1d7e9e71-0b99-4ac9-aa3c-42cacaf20c44:4727:40)
    at Troll.doBossBattle (userscript.html?name=HaremHeroes-Automatic%252B%252B.user.js&id=1d7e9e71-0b99-4ac9-aa3c-42cacaf20c44:4782:27)
    at Proxy.autoLoop (userscript.html?name=HaremHeroes-Automatic%252B%252B.user.js&id=1d7e9e71-0b99-4ac9-aa3c-42cacaf20c44:15160:34)

    at Gt (<anonymous>:9:89)
    at t.<computed> (<anonymous>:64:150)
    at Gt (<anonymous>:9:89)
    at r (<anonymous>:23:484)
    at <anonymous>:24:112
    at <anonymous>:74:344

in HH when I enable the Battle Troll option, most probably due to the addition of the world 17 boss. I have no problems in CxH or PH.

HH_DebugLog_1703087021629.log

deuxge commented 10 months ago

Select a troll option (not first or last with girls) to avoid the issue for now

deuxge commented 10 months ago

I am getting


Uncaught TypeError: Cannot set properties of undefined (setting '0')

fixed

deuxge commented 10 months ago

New in 7.1.0

Some updates, add unit tests and necessary files
Do not run on update page, when there is no jquery
Add missing files
Try to force event mythic fights n1 from #547
refactor ConfigHelper and NumberHelper into class
Remove global usage of Trollz and Leagues
Fix some bugs in condition in booster module

Roukys / HHauto

Bug 7.0.0 - Bug findings #1134