Roukys / HHauto

GNU General Public License v3.0
43 stars 45 forks source link

Bug [7.12.8] - Multiple regressions after game update of june 5th #1277

Closed Franck-75 closed 2 weeks ago

Franck-75 commented 1 month ago

Hi, After the todays update, many regressions occurs.

For the moment, the affected identified functionnalities are :

Thanks for your corrections.

Sagie23 commented 1 month ago

I got this too

deuxge commented 1 month ago

Salary and pop should be fixed

Franck-75 commented 1 month ago

Thanks. It works well for the two issues you mentionned. But the third issue is still present and need also correction.

Dimka2010 commented 1 month ago

not working compact functions Screenshot_4 Screenshot_5

Cirkulis commented 4 weeks ago

:x: is almost covered here, in Labyrinth it's invisible.. 2024-06-06  00-01-29

deuxge commented 4 weeks ago

Last two were already found and are fixed now.

Dimka2010 commented 4 weeks ago

Place of power GUI bug

Screenshot_6

its the same "compact" button mistake

Franck-75 commented 4 weeks ago

And still the 150 kobans / gold wins at the end of the mission is not working.

shiy0805 commented 4 weeks ago

I got the same issue with PoP, updated script still not working

deuxge commented 4 weeks ago

And still the 150 kobans / gold wins at the end of the mission is not working.

I know, I didn't say it fixed

I got the same issue with PoP, updated script still not working

Main issue with pop was about it not working. Now it is. can you confirm ? If not I need more info than that. The button size is a minor issue for me... and not yet fixed

deuxge commented 4 weeks ago

And still the 150 kobans / gold wins at the end of the mission is not working.

fixed now

Place of power GUI bug

Screenshot_6

its the same "compact" button mistake

fixed

Franck-75 commented 4 weeks ago

Not sure that mission part is resolved. I already took the 150 kobans and I still have 15' mission countdown every 15'. The button "Come back to city" is not seen.

shiy0805 commented 4 weeks ago

And still the 150 kobans / gold wins at the end of the mission is not working.

I know, I didn't say it fixed

I got the same issue with PoP, updated script still not working

Main issue with pop was about it not working. Now it is. can you confirm ? If not I need more info than that. The button size is a minor issue for me... and not yet fixed

yes PoP functions not working. Tried disable HH++ and precision , still not working previously it went into the assign page and can't assign. Now its just stuck at the overview page. also when im doing PoP manually, sometimes when I go out the order of missions is not in numerical order. So I tried entering PoP mission and return to overview about 20 times without script, they are always in the correct order. When I do this with script enabled, sometimes the order will mess up. You can recreate this situation when you go into PoP overview without script, then enable script, and the order will be messed up.

deuxge commented 4 weeks ago

Can you please share your logs when you get stuck ? I don't have any issue on pop (I have "all" and no precision)

Not sure that mission part is resolved. I already took the 150 kobans and I still have 15' mission countdown every 15'. The button "Come back to city" is not seen.

On my side I have the button and the timer is fine. Can you share a logs when it goes to mission page ? or screen ? For sure the timer needs the time on the mission page

shiy0805 commented 4 weeks ago

Can you please share your logs when you get stuck ? I don't have any issue on pop (I have "all" and no precision)

Not sure that mission part is resolved. I already took the 150 kobans and I still have 15' mission countdown every 15'. The button "Come back to city" is not seen.

On my side I have the button and the timer is fine. Can you share a logs when it goes to mission page ? or screen ? For sure the timer needs the time on the mission page

HH_DebugLog_1717671761883.log you can see at the end its stuck in a loop from what I see I would assume the script can't access "page 5" and its causing the loop? I don't know how this script works its only a guess. Also earlier today I think when I first found this bug I was able to solve it by manually finishing the PoP and it can continue from there, but it doesnt work later today.

deuxge commented 4 weeks ago

HH_DebugLog_1717671761883.log you can see at the end its stuck in a loop from what I see I would assume the script can't access "page 5" and its causing the loop? I don't know how this script works its only a guess. Also earlier today I think when I first found this bug I was able to solve it by manually finishing the PoP and it can continue from there, but it doesnt work later today.

Ok, this is because one of the pop is not available. and the behavior changed. Instead of showing an empty pop page, you are back into the main pop page...

shiy0805 commented 4 weeks ago

HH_DebugLog_1717671761883.log you can see at the end its stuck in a loop from what I see I would assume the script can't access "page 5" and its causing the loop? I don't know how this script works its only a guess. Also earlier today I think when I first found this bug I was able to solve it by manually finishing the PoP and it can continue from there, but it doesnt work later today.

Ok, this is because one of the pop is not available. and the behavior changed. Instead of showing an empty pop page, you are back into the main pop page...

I didnt know this script has a debug feature until you mentioned. Anyways glad we figured it out, keep up the great work.

deuxge commented 4 weeks ago

I can't really test this use case right now, but the fix I provided should solve the issue. let me know

shiy0805 commented 4 weeks ago

I can't really test this use case right now, but the fix I provided should solve the issue. let me know

HH_DebugLog_1717678040041.log still having the same issue

deuxge commented 4 weeks ago

It seems you have strange values in the pop variables.

Could you use the debug menu and clean temp variables: image Hopefully it will help.

if you manually set the filters, you need to update manually or use the "do all". image

I will continue to work to ensure this do not happens again but I need to reproduce and I don't succeed...

shiy0805 commented 4 weeks ago

It seems you have strange values in the pop variables.

Could you use the debug menu and clean temp variables: image Hopefully it will help.

if you manually set the filters, you need to update manually or use the "do all". image

I will continue to work to ensure this do not happens again but I need to reproduce and I don't succeed...

that might be the cause, I used the "do all" function and now its working. I think it might be because I have a custom index filter thats not in numerical order. Also, do you know which where can I find the code that handles "precision"? I want to try optimize. Because when I mannually set PoP I can get 11 x 6h, and with "precision" I'm only able to get 10x 6h. I think its because it uses the girls from top first when ideally you want to select efficient girls from bottom and go up( because the limit to number of girls you can sent per mission)

deuxge commented 4 weeks ago

Also, do you know which where can I find the code that handles "precision"? I want to try optimize. Because when I mannually set PoP I can get 11 x 6h, and with "precision" I'm only able to get 10x 6h. I think its because it uses the girls from top first when ideally you want to select efficient girls from bottom and go up( because the limit to number of girls you can sent per mission)

Here : https://github.com/Roukys/HHauto/blob/main/src/Module/PlaceOfPower.ts#L328

deuxge commented 4 weeks ago

So to my knowledge all regression seems fixed. let me know if you have something else

shiy0805 commented 4 weeks ago

So to my knowledge all regression seems fixed. let me know if you have something else

Do you mind adding me on discord (skeptic85) ? I have a few questions I think its faster to message in discord

Franck-75 commented 4 weeks ago

For me, it's OK. If no one complains in the next 24 hours, I'll close this ticket. Thanks.

UncleBob800 commented 4 weeks ago

@deuxge "xx.06.2024, xx:xx:xx.xxx:Missions.run": "ERROR during mission run: Cannot read properties of null (reading 'style'), retry in 10min", P.S. It wouldn't be bad for me to also be able to contact you on discord. Add me too pls. unclebob800 in discord

UncleBob800 commented 4 weeks ago

@deuxge, in Harem page button "Girl Page" no longer works because the girl's upgrade page address has changed. Previously it was: https://www.hentaiheroes.com/characters/<girl id>?resource=experience But now the page address looks like this: https://www.hentaiheroes.com/girl/<girl id>?resource=experience For this button need to replace characters with girl in the link address.

deuxge commented 4 weeks ago

@deuxge "xx.06.2024, xx:xx:xx.xxx:Missions.run": "ERROR during mission run: Cannot read properties of null (reading 'style'), retry in 10min",

I don't get this, what is the use case ? game ?

@deuxge, in Harem page button "Girl Page" no longer works because the girl's upgrade page address has changed. Previously it was: https://www.hentaiheroes.com/characters/<girl id>?resource=experience But now the page address looks like this: https://www.hentaiheroes.com/girl/<girl id>?resource=experience For this button need to replace characters with girl in the link address.

No in fact it was girl everywhere before. But now on harem it is characters so I changed everywhere. But it is not for some... will fix

shiy0805 commented 3 weeks ago

is there a way to access a girl's Charm and Know-how stats in a Hardcore PoP? I'm looking at the code and it seems like you are using girl.power to get the power for the corresponding power of the PoP( so if the PoP is hardcore its getting the hardcore of the girl). Im thinking to add a power ratio = rquired stat / the higher of the other two stat, so you will always pick girls with high ratio.

deuxge commented 3 weeks ago

is there a way to access a girl's Charm and Know-how stats in a Hardcore PoP? I'm looking at the code and it seems like you are using girl.power to get the power for the corresponding power of the PoP( so if the PoP is hardcore its getting the hardcore of the girl). Im thinking to add a power ratio = rquired stat / the higher of the other two stat, so you will always pick girls with high ratio.

We should continue this discussion in this ticket : https://github.com/Roukys/HHauto/issues/929

Franck-75 commented 3 weeks ago

I think it's time to close this ticket now ?

Senyor-K commented 3 weeks ago

The missions themselves are completed properly and when the bot finishes the missions it claims the reward and is able to find the restart timer for the daily missions without problem, but the bot is not able to find the timer for the daily missions if it tries to do it a second time, that is, once it finishes the missions and claims the reward it has no problem finding the timer but if this function tries to find the timer again, either because the cache has been cleared or because the game has been closed and reopened, it is no longer able to find this timer and restarts every 10m or so.

Case 1: Enough girls power to do all the pop's at the same time (6h) and claim the rewards at the same time, do all activated.

There is no problem here other than the bot claiming the rewards by entering directly on the page of each pop instead of doing so from the main pop page, which I think would be more natural.

There is also a pause of about 1m between claiming the rewards and starting the new pop's, I understand why this happens when there are still active pop's and it is better that way, but I don't understand why the bot does this when there are no active pop's, it is unnecessary, although it is also a not very relevant issue.

Case 2: Insufficient girls power to do all the pop's at the same time and claim all the rewards at the same time, that is, you can start all the pop's but some of them take more than 6 hours to complete, do all activated.

Here the bot properly starts the pop's according to the player's possibilities the first time, but the next time, when it is supposed to come back to claim the rewards at the end of the lowest timer pop and then start a new round of pop's, the bot tries to do both tasks, claiming rewards and starting pop's, in the same round, making it all a mess. That is, the bot does not claim all the rewards in one round and then start new pop's in another round, instead it does both at the same time causing strange behaviors like starting certain pop's instead of others or leaving certain pop's unstarted until the next round (the time the next active pop ends and then returns to check the pop's again), leaving these pop's unstarted during that entire period of time.

The optimal behavior here would be for the bot to work as before, that is, when reviewing the pop's, to begin with it should claim all the rewards, ""then it should start all the pop's that it could start"" and lastly it should review the pop's again to take the lowest timer as a reference and repeat the process.

Case 3: Custom pop's index, do all disabled.

In this case it does a rather strange thing, instead of claiming all the rewards and then starting the specified pop's, it goes 1 by 1 doing these tasks interspersedly, that is, it claims the reward of pop A and immediately starts pop A, then it goes to pop B and does the same and so on. Also sometimes it gets stuck on the main pop page, I think it happens when a pop expires and disappears but the bot keeps trying to start it.

The optimal and most natural behavior would be for the bot to claim all the rewards first and then start the pop's following the established order, in addition to checking that the expired pop's do not affect you.

I attach several logs that could help to solve this. HH_DebugLog_1718103926970.log HH_DebugLog_1718103991944.log HH_DebugLog_1718104061475.log HH_DebugLog_1718127322036.log HH_DebugLog_1718127417961.log HH_DebugLog_1718127431787.log

deuxge commented 3 weeks ago
  • A little problem with the daily missions function, it is not serious but it is annoying.

I guess this I can have a look again but I do not had it myself... I will look in your logs if I can found something

* Several problems with the pop's function.

This, I do not see them linked to the last update. I this case, it should be in différent tickets.

Case 2 is already opened : https://github.com/Roukys/HHauto/issues/929 Also you have the option 'wait max' to wait for the longest pop before going again.

Case 3 please open a dedicated ticket

I want to keep ticket separated for issues. If not it is a complete mess to keep track. In such game update I can accept when it is small fixes. Your pop things seems not to be easy fix... Please open other tickets and I will have a look What I can do

Senyor-K commented 3 weeks ago
  • A little problem with the daily missions function, it is not serious but it is annoying.

I guess this I can have a look again but I do not had it myself... I will look in your logs if I can found something

ok, no hurry, thanks.

  • Several problems with the pop's function.

This, I do not see them linked to the last update. I this case, it should be in différent tickets.

Case 2 is already opened : #929 Also you have the option 'wait max' to wait for the longest pop before going again.

Case 3 please open a dedicated ticket

I want to keep ticket separated for issues. If not it is a complete mess to keep track. In such game update I can accept when it is small fixes. Your pop things seems not to be easy fix... Please open other tickets and I will have a look What I can do

I put it here because all these changes in the bot's behavior with respect to pop's arose as a result of the last update, but if you prefer them in separate tickets, ok.

Cirkulis commented 3 weeks ago

I also have the described problem with daily missions

"1:41:26 AM.118:Generator.next": "Time to do missions.",
"1:41:26 AM.122:Missions.run": "Navigating to missions page.",
"1:41:26 AM.126:gotoPage": "going home->missions",
"1:41:26 AM.129:gotoPage": "setting autoloop to false",
"1:41:26 AM.132:gotoPage": "GotoPage : /activities.html?tab=missions in 481ms.",
"1:41:26 AM.136:Generator.next": "lastActionPerformed changed to mission",
"1:41:26 AM.138:Generator.next": "autoLoop Disabled",
"1:41:32 AM.839:Generator.next": "Time to do missions.",
"1:41:32 AM.843:Missions.run": "On missions page.",
"1:41:32 AM.850:Missions.parseMissions": "Found 0 missions to be parsed.",
"1:41:32 AM.852:Missions.run": "No missions detected...!",
"1:41:32 AM.854:Missions.run": "Refreshing to collect gift...",
"1:41:33 AM.370:Generator.next": "Time to do missions.",
"1:41:33 AM.372:Missions.run": "On missions page.",
"1:41:33 AM.377:Missions.parseMissions": "Found 0 missions to be parsed.",
"1:41:33 AM.379:Missions.run": "No missions detected...!",
"1:41:33 AM.381:Missions.run": "Collecting gift.",
"1:41:33 AM.384:Missions.run": "ERROR during mission run: Cannot read properties of null (reading 'click'), retry in 10min",
"1:41:33 AM.387:setTimer": "nextMissionTime set to 19886:01:52:00 (10:27)",
"1:41:33 AM.392:Generator.next": "lastActionPerformed changed to none",
"1:41:41 AM.917:Generator.next": "Back to home page at the end of actions",
"1:41:41 AM.921:gotoPage": "going missions->home",
"1:41:41 AM.924:gotoPage": "setting autoloop to false",
"1:41:41 AM.926:gotoPage": "GotoPage : /home.html in 420ms."
Dimka2010 commented 3 weeks ago

Not working this button-function after latest game update. Its from Harem Screenshot_1

deuxge commented 3 weeks ago

I do not forget the others

Dimka2010 commented 3 weeks ago

i am not the expert of code, but.. maybe if the problem was in the renaiming this one Screenshot_4

maybe probably inside script was another no-renaming part of this girl-characters renaming? can you check please.

deuxge commented 2 weeks ago

Before 5th of june, /girl/ was the one everywhere. Now some changed to /characters/. I thought all of them and changed all. But I shouldn't. I has been solved with 7.12.18.

deuxge commented 2 weeks ago

Missions issues should be fixed. Pop issues as well (hopefull)

Let me know if you found anything

Senyor-K commented 2 weeks ago

Missions issue seems solved. Thanks.

Pop's issues seems solved as well.

Senyor-K commented 2 weeks ago

New issue related to missions function.

If all missions are finished before the "wait for contests" timer expires (which is when the bot would claim the rewards) the bot automatically sets the timer to the next day, for the start of the new missions, leaving the current ones unclaimed.

Senyor-K commented 2 weeks ago

The previous issue is solved but a small issue has arisen with the timer again, instead of perfectly adjusting to the mission reset time as it did before, 12:00 UTC+0, it does so with a few seconds difference . I think it is because when setting the timer it does not take seconds into account.

It is not serious but I am telling you in case you want to take a look at it, to make it perfect.

Otherwise everything is correct, thanks for the fixes.

deuxge commented 2 weeks ago

No this is expected. I always add a random time to all timers. To avoid having the bot going to the item right when the timer ends, meaning making something more human (a bit)

Franck-75 commented 2 weeks ago

The last messages are not related to the june 5th update. So I close this ticket, the initial purpose is resolved. Thank you for your (rich) contributions and corrections !