Roukys / HHauto

GNU General Public License v3.0
45 stars 44 forks source link

Need tests for Beta Version #16

Closed Roukys closed 3 years ago

Roukys commented 3 years ago

Hello all,

I would need some tests before commiting the new version :)

Installation https://github.com/Roukys/HHauto/raw/beta/HHAuto.user.js

Modifications : https://github.com/Roukys/HHauto/milestone/1

Script will automatically go back to main release 5.1.0 when it will be published (depending of your setting in Tampermonkey or other)

OldRon1977 commented 3 years ago

That's it!

On french it works: image

As soon as the fix is there I keep on testing :)

Roukys commented 3 years ago

@OldRon1977 here you go : https://github.com/Roukys/HHauto/raw/beta/HHAuto.user.js 5.1-beta.8

OldRon1977 commented 3 years ago

Works fine :)

image

wastymon commented 3 years ago

Hello, I use Firefox and I realized that the script did not work well for me.

I noticed that I was stuck in season, so after much looking and testing, I came to the fact that outerText Property is not supported by Firefox. I don't know if something could be done about it, but I leave the restlessness.

https://www.w3schools.com/jsref/prop_node_outertext.asp

I have version 82.0.2 (64-bit).

Thanks a lot.

Uncaught TypeError: document.getElementsByClassName(...)[index].getElementsByClassName(...)[0].children[2].outerText is undefined

Roukys commented 3 years ago

@wastymon can you try and replace it by innerText ?

I'm trying on my side also, it should solve your issue

Roukys commented 3 years ago

@wastymon : https://github.com/Roukys/HHauto/raw/beta/HHAuto.user.js 5.1-beta.9 :)

Roukys commented 3 years ago

@Knatan @wastymon @OldRon1977 I'd like to be able to publish beta so it will update for all do you see any other bugs in it ?

OldRon1977 commented 3 years ago

At the moment I don't see any more bugs...

wastymon commented 3 years ago

Hello again, now it works fine. I don't see any more bugs. Thank you very much for this excellent work.

Roukys commented 3 years ago

I'll push beta in main tomorrow I think. then we'll see next milestone :)

Knatan commented 3 years ago

In 5.1-beta.10 I have noticed that you are duplicating the OCD script for the League page. So it will end up looking confusing like this: Untitled Option 1: to not step on the other script's toes and remove the counter from the League page. Option 2: relocate the position so they don't clash. Option 3: make them more identical, so they exactly overlay each other.

You would have the better advantage when running both scripts. If the game changes its mechanics, the other script will adapt to new mechanics, and then you will be better able to compare the numbers in /tower-of-fame.html (their script) vs /battle.html (your script).

Roukys commented 3 years ago

5.1-beta.11 : https://github.com/Roukys/HHauto/raw/beta/HHAuto.user.js

changed position and Icons of powerCalc

Added an icon for chosen Opponent in season