Script issues in Hentai Heroes [5.4.5 and below(?)]

dadanda commented 3 years ago

Describe the bug The script gets stuck/runs slower in Hentai Heroes.

I have 2 accounts, 1 in Harem and 1 in Hentai. The settings for both accounts are the same. Both accounts are similar in almost everything. I have a tab reloader on both tabs set to 5mins(now set to 1 hour to lessen the interruption) But for some reason, whenever I switch to Hentai, the script is usually stuck in AutoSal and usually resumes when I have it as an active window. But for Harem, it's working for most of the time. The scripts running on both are this and the OCD script. On Nutaku, there is one additional script which is the Nutaku reload helper that Dorten D. did when they were the lead.

System:

OS: Windows 10
Browser: Chrome 88.0.4324.182
Script-Helper: Tampermonkey 4.11
Script-Version: 5.4.5
Actual activated options: :

cossname commented 3 years ago

try to open them in different windows(not tabs inside same window)

dadanda commented 3 years ago

try to open them in different windows(not tabs inside same window)

yeah thats what I've been doing for however long I am playing with both accounts.

Roukys commented 3 years ago

@dadanda you have many girl and no monthly card ? I've got an issue on my side lately where script goes for way too long on get salary. Thinking of way to reduce it or cut it when paranoia comes ...

dadanda commented 3 years ago

@dadanda you have many girl and no monthly card ? I've got an issue on my side lately where script goes for way too long on get salary. Thinking of way to reduce it or cut it when paranoia comes ...

Yeah, that's the case. If I don't have it on, I'll eventually drain my bank. I think a workaround at the moment is maybe making the priority of AutoSal the least? Like if some of the other timers are done, it would interrupt the AutoSal to do it. But then it would definitely mess somethings up.

Roukys commented 3 years ago

yes I'm thinking on something like that, auto salary is the last one so normally other should have run, but that is not always the case.

Your idea is good, only run salary when no others need to run, I've gotta check, issue is that is will seems not to work for people.

Implementation could be as easy as remove the fact that during salary the autoloop is blocked

Roukys commented 3 years ago

trying that on my side, salary will not block script, therefore if any thing is time's up it will run, including paranoia

dadanda commented 3 years ago

trying that on my side, salary will not block script, therefore if any thing is time's up it will run, including paranoia

how is it running?

Roukys commented 3 years ago

not good for the moment ... tried another thing, seems collect money check at the end if any news, may means that it can run indefinitely, tried a fix on that to see ...

Roukys commented 3 years ago

ok not a good idea if you deactivate an option, its timer stay activated and will block getSalary I need a clean timers function ...

OldRon1977 commented 3 years ago

You can clear timers via the debug menu:

Was that the option you were looking for?

Roukys commented 3 years ago

:) no I was meaning that this list will contains timer outdated if you put a function off its timer will stay.

so in my test I was checking that no time's up appart salary and was stopped by other timers of function no longer active ...

but that was a good guess :)

In fact I need to :

see that salary only runs when other don't (only for non monthly card get salary...)
see that it can be interrupted any time by any time's up ...

dadanda commented 3 years ago

So as of the moment, I could technically apply the changes and have it work to some degree but it needs new functions to work the way it supposed to do?

Roukys commented 3 years ago

@dadanda can you try this one : https://github.com/Roukys/HHauto/raw/better-salary/HHAuto.user.js it does seems to do the trick for me, issue was salary do check if more salary at the end, with many girl it is nearly an infinite loop ...

dadanda commented 3 years ago

@dadanda can you try this one : https://github.com/Roukys/HHauto/raw/better-salary/HHAuto.user.js it does seems to do the trick for me, issue was salary do check if more salary at the end, with many girl it is nearly an infinite loop ...

Alright, I tested it over a few hours and it seems to work for the most part just that, it's still not working as well as it should be. (There's a bunch of combativity not used when I forcefully stopped the script from running and a bunch of functions waiting for AutoSal to finish) What is your min wait time so that I can replicate it one-to-one?

Roukys commented 3 years ago

in fact for the moment I was not able to stop it runs if any other needs, only not to check after collecting if new salary to collect Old behavior : get all salaries, collect them, get if new salaries, collect them -> loop New behavior : get all salaries, collect them -> then set next auto salary.

I've set it to 10 mins

dadanda commented 3 years ago

in fact for the moment I was not able to stop it runs if any other needs, only not to check after collecting if new salary to collect Old behavior : get all salaries, collect them, get if new salaries, collect them -> loop New behavior : get all salaries, collect them -> then set next auto salary.

I've set it to 10 mins

alright, it seems to be working well, even if the timer is set low. at times it can get stuck for some reason or another but it's working fine.

Roukys commented 3 years ago

yes I'll try to improve, I'm working on other things on this version and will publish it soon :) it should auto update when main will be updated :)

Roukys commented 3 years ago

5.4.6 : Salary:

try to fix issue with salary and paranoia for big harem and no monthly card #172

Roukys commented 3 years ago

@dadanda can you check #178 I think this is the real issue. Since I'm running in differents windows I no more have the issue

Roukys / HHauto

Script issues in Hentai Heroes [5.4.5 and below(?)] #172