Roukys / HHauto

GNU General Public License v3.0
45 stars 44 forks source link

There is a long-standing scaling problem #232

Closed cereushy closed 3 years ago

cereushy commented 3 years ago

When I used a 125% zoom display in Win10 + Chrome system, the menu of Hhauto could not be fully displayed, and continued until version 5.4. There was a short period of time when it was normal, but soon the problem came back and continued until now. 20210602221810

cereushy commented 3 years ago

20210602221910

YotoTheOne commented 3 years ago

@cereushy can you try this and tell me if it works, and post a screenshot otherwise ? https://github.com/YotoTheOne/HHauto/blob/Better-UI-menu/HHAuto.user.js Here it works until 250% zoom on Chrome, the original menu from the game gets unusable though.

cereushy commented 3 years ago

@YotoTheOne here you go , the 125% scale I made in windows not chrome , and then when I opened Chrome again, the bug was permanent . 20210602231923

YotoTheOne commented 3 years ago

What's that banner on bottom ? Nutaku thing ? I'm thinking maybe menu is hidden behind it, but since Roukys already set z-index to 1000 I don't think we can do anything about it... Is there no way to hide it on your side ? Why not reset win10 zoom and zoom within Chrome ? Maybe you need the zoom for other apps...

Edit : can you try to replace GM_addStyle('span.HHMenuItemName {font-size: xx-small; line-height: 150%;}'); with GM_addStyle('span.HHMenuItemName {font-size: smaller; line-height: 100%;}');

cereushy commented 3 years ago

@YotoTheOne "line-height: 100%" - The change is valid, the problem has been solved, thank you. The occlusion at the bottom is the original banner of the web page, and I think it was placed further forward, so it blocks the UI. As you said, I have reset Win10 zoom to 100%, but the enlarged UI is still unable to show the integrity, I think this is a small probability issue 20210603012701 .

YotoTheOne commented 3 years ago

So it does work on your side with only line-height: 100% ? No font size change ?

What about 120% ? And GM_addStyle('span.HHMenuItemName {font-size: smaller; line-height: 120%;}'); ? It may not be a very long-term solution, as the menu could expand if new options are added.

Could you also try adding height:auto; in UIcontainer.html( '<div style="font-size:x-small;position: absolute;right: 22%;width: inherit;text-align: left;display:flex;flex-direction:column;justify-content: space-between;z-index:1000" id="sMenu">' ? Result : UIcontainer.html( '<div style="font-size:x-small; position: absolute; right: 22%; width: inherit; height:auto; text-align: left; display:flex; flex-direction:column; justify-content: space-between; z-index:1000" id="sMenu">'

Edit : could also work with height:50% since it seems the game takes about 50% of the page height, and header, banner and footer about 50%.

NinJaraya commented 3 years ago

I use the Stylus extension and made a style that makes Nutaku look like HH: `@-moz-document url("https://www.nutaku.net/games/harem-heroes/play/"), domain("osapi.nutaku.com"), domain("haremheroes.com") { .game-frame,

hh_game,

[style="height: 973px;"] { height: 100vh!important; } body, html { height: 100vh!important; overflow: hidden!important; } iframe#hh_game { max-height: 100vh!important; } .header-play, img.hh-promo, .game-play-footer, footer, img[src^="http://ctrack"] { display: none!important; } }` If anyone wants to turn this into a script, feel free.

by Google Translate

cereushy commented 3 years ago

@YotoTheOne Yes it does work on with only line-height: 100% .

20210604234509 This is line-height: 120% , a few part is out of the side.

20210604234933 This is line-height: 120% plus height:auto; a few part is out of the side , all options are aligned to the left .

20210604235303 This is line-height: 120% plus height:50%; a few part is out of the side , and background image missing.

Hope they will help you .

Just see the 5.4.30 vision is all good work on my computer without any manually modify. 20210605000040

cereushy commented 3 years ago

@NinJaraya Actually I don't know much about programming , I don't know how to use your modifications, sorry I can't help thanks anyway.

Roukys commented 3 years ago

@cereushy if it is ok for you in last version, can you close the issue ? Thanks

cereushy commented 3 years ago

@cereushy if it is ok for you in last version, can you close the issue ? Thanks

Sure thank you .