Roukys / HHauto

GNU General Public License v3.0
45 stars 44 forks source link

Bug [5.5.50] - Hang when Leagues season ends #369

Closed night-ghost-1 closed 2 years ago

night-ghost-1 commented 3 years ago

Describe the bug (Nutaku) After current season in Leagues ends, script goes to leagues screen and just sits there doing nothing. The attached screenshot was taken when about 45 minutes passed since script went to that screen. Also see debug log, it looks like opponent list parsing won't start for some reason: HH_DebugLog_1633002468864.log If you hit the 'Refrest opponent list' button manually, everything starts to work fine

To Reproduce Just wait for a season to end, I guess. Also see activated settings: HH_SaveSettings_1633014678790.txt

Screenshots Screen where everything hangs:

screenshot

Settings:

settings

System:

Additional information Github decided to tear down my previous account, so I have to recreate this issue. Here are the answers to questions and suggestions that arised last time:

cossname commented 3 years ago

im have a guess, this can happen bcs of "opponentsListExpirationDate" didnt reached 1 hour to reset opponents list, also script doesnt know thats new league started, bcs your collect switch set to off

so if my guess is right, you would have new opponet list after anoter 15 minutes (1hour in summ)

Roukys commented 3 years ago

@DrkMfn2 there are 2 hypothesis here. one is as @cossname said, the list is still the old one with old IDs, but still a few one should work. Second one is the following : script calculate the number of point you should have, under the 15th player to stay => but at start the score of number 15th will be 0 or at least not enough so that if you win a fight you'll not go above place 15, therefore script doesn't do anything

Roukys commented 3 years ago

@DrkMfn2 ok so seeing your log, I confirm that it is linked to the list which is still the old one, I'll check to add a check so that list expiration is at max the league end if I can in the mean while you can just refresh the list manually via the button if it happens

night-ghost-1 commented 3 years ago

@Roukys thanks! Personally I can live with an outdated list if it still updates eventually (I'll check it this Thursday), but I think the main problem here is that script is not doing anything else (troll battles, season, salary, etc) for an hour until list updates. Can you try to do something with that if you won't be able to correctly process league end?

cossname commented 3 years ago

@Roukys if you cant attack opponent, try to delete selected opponent form list, also if selected opponent = "-1", refresh list

Roukys commented 3 years ago

@DrkMfn2 working on a way to prevent it. @cossname on -1 refresh list can't be solution as if you've fought everyone it will be a -1 and it will loop. I'm finishing a bit of code to make expiration be at max league end :)

Roukys commented 3 years ago

delivered in v52, lets see next week :)

night-ghost-1 commented 3 years ago

Tried it today, looks like everything works fine after the fix, at least on my side