Roukys
commented
3 years ago hello @Tucho1m,
Glad to see you here :)
Many good ideas here,
my thoughts : 1 : yes very good idea, I'll try to separate collect from autoFill :) would be much more effective 2 I'll check but normally should not do it I'm using a for loop to parse through the powerplaces :) 3 same thing, the for loop combined with the fact I'm keeping each counter should do the trick => counter launched means autofill is done 4 : same as one
for autoleague I'll open it as a new enhancement :)
by the way, even if I'm just familiarizing myself with github, if you're willing to help for code I'm taking :D
Branches are very useful to test on developpement
Tucho1m
OldRon1977
@Roukys Nice job you did with HH I didn't know that github could be used this way. First, thank you for your work and time.
In all the scripting attempts I was doing, I found things that can help a little to reduce POP load that repeats 3x3 times.
*- You can collect all the rewards at once, but with one condition, that all the PoPs have finished the time and have given the reward. If this condition is met, on the page activities -> place of power you can collect all the rewards. By doing this you are free to go to Autofill things.
*- It is not recommended to return to the home page (harem) when the function is running, only when it has been completed. Example: I finish doing the Autofill then go back to activities -> places of power. And then you go find the time. All completed tasks return to the home page.
*- A problem to be considered is whether the "Autofill" of all PoPs is done in a one-time function, since it takes time and if it is interrupted, it has to "know" where it was interrupted to continue from there (or repeat).
*- In the same way that you collected the rewards you can also collect the time of each PoP in activities -> places of power. all in 1 attempt but only if all PoPs were completed.In my script, I only saved the longest wait time, with this I made sure that all the PoPs have finished the tasks.
I know that several things I said are not very "compatible" with the way you programmed PoP. But I think that in the long run this will be a problem if more PoPs are added, and that this single function will be very time consuming, as it is more likely to be "interrupted by another function", there is the option to activate the "busy function". But it is not fully implemented in all other features and all should be checked to work properly.
It is recommended that AutoPoP be executed under the protection of the "Busy" function and if the execution is "interrupted" by the page refresh, force the repetition of the last function that was executed with "busy" activated.
It is important when you first start in HH and have a low level to be able to select which PoP you want to do, because it does not have enough power to do others that are not your main stat. For the other top tier players I'd like it to "auto-detect" how many PoPs are available and do all of them (In my script add 1 more to the total, just in case ...). This worked quite well in mi case. Integrate this with "what PoP do you want to do?" this would be a new button next to "PowerPlaces" that says "All" and then "Index Filter". When "All" is enabled it ignores "Index Filter" and do all PoP available. I love the "AutoShits" stuff.
This is a lot to consider, I just wanted to say my point of view, implementing all this is a lot of long-term work and testing, if the "All" button is added for places of power, I'm happy with just that :)
On the other hand, the "Autoleague" function does not collect the reward when one league ends and another begins, directly fight, leaving the "reward" to collect on the league screen and you do not see the players, a user should not be able to fight if I did not collect the reward. This is solved by adding below line 1470 this:
$('#leagues_middle .forced_info button[rel="claim"]').click(); //click rewardAll I said is to make the script "look" a bit more to a normal user. Wow I didn't want to write that much but if I wanted to be specific, I hope everything I wrote is understood.