Roukys / HHauto

GNU General Public License v3.0
45 stars 44 forks source link

Mission Bug [5.6.51] - Missions doesn't collect. #450

Closed dadanda closed 2 years ago

dadanda commented 2 years ago

On some of my tabs (I have a Harem, Hentai, and both Comix accounts), the missions don't get collected. So the Koban daily bonus for completing it doesn't appear and gets collected. (I had one with all the missions collected and one with missions not collected and checked at 5 mins before reset. The one with missions collected is fine, the other has daily missions reset set to the time at reset. I don't know whether it would collect but didn't risk it. HH_DebugLog_1642162439674.log

Dimka2010 commented 2 years ago

all missions collected good in 5.6.39 Screenshot_33

dadanda commented 2 years ago

I have both items selected and still they didn't collect at 5 mins before reset.

all missions collected good in 5.6.39 Screenshot_33

dadanda commented 2 years ago

I deselected Kobans first and the issue persists. it can at times not collect it. image image The AutoMissions do work, just the collection might need to check again sometime before the refresh.

Roukys commented 2 years ago

@dadanda I've made a fix concerning mission tab not working if already on mission tab. Could be a reason, do tell me if it seems better with v44

dadanda commented 2 years ago

@Roukys had another case of it not getting claimed. But haven't checked whether it will collect later on before the reset. Will be checking and updating. image

dadanda commented 2 years ago

comix comix2 There are still cases of it not collecting @Roukys.

Roukys commented 2 years ago

:( ... I'll try to find from the code directly but not trivial.... did you identified a context in which it happens ?

dadanda commented 2 years ago

:( ... I'll try to find from the code directly but not trivial.... did you identified a context in which it happens ?

It's very inconsistent as it's not game-specific, as I can find cases of it happening in Hentai and Harem, as well as Nutaku Comix. It doesn't happen all the time as some people have said they have not found an issue with it. The only thing that might be affecting it is that the script gets interrupted by the page refresher when it's doing the collecting. A possible solution is to maybe have additional checks if there's something collectible maybe, or when it does collect, try to collect everything (that happens when I reset the timer when it is set to the game rollover time.) Or 5 mins or something similar before the rollover to the new "day" it will try to collect or something.

Dimka2010 commented 2 years ago

maybe you run a multi-hour task (which requires 3-4-5 hours to complete) end-to-end or after the bot could collect a reward on the current game day on the current day.So it turns out that this task not completed "yesterday" is no longer taken today?

dadanda commented 2 years ago

maybe you run a multi-hour task (which requires 3-4-5 hours to complete) end-to-end or after the bot could collect a reward on the current game day on the current day.So it turns out that this task not completed "yesterday" is no longer taken today?

I've seen it happen during regular, non-Event days so it's not because of long missions.

dadanda commented 2 years ago

image Tested the script after the latest update: had a case of not collecting, quest was an event quest. will continue updating this comment with later tests.

dadanda commented 2 years ago

@Roukys had a case of it not collecting even within the last 2 hours. (but was 1 update late) (also how does it get auto updated, because it seems to be not autoupdating on my end.)

Roukys commented 2 years ago

I'll do a check on that ... for update do check in tampermonkey then in script parameters that auto update is checked. It auto disable if you edit the script manually

dadanda commented 2 years ago

@Roukys image didn't collect the last 2 days, it was fine then its not. the safeguard to collect 1 hour doesn't seem to have worked. Then again I'm running multiple instances of the game and for the others its fine.

Dimka2010 commented 2 years ago

right now - i think - the roots of this "problem" are here https://github.com/Roukys/HHauto/issues/482

Roukys commented 2 years ago

@Dimka2010 I've tried to fix the DST issue, please check :)

Dimka2010 commented 2 years ago

for me = all working fine

dadanda commented 2 years ago

HH_DebugLog_1650279423652.log image

Out of 4, 1 still didn't collect. Had some other cases of the others not collecting.