Roundaround / mc-fabric-pickup-notifications

MIT License
4 stars 0 forks source link

Blocks picked up are seperate from stack, and crash on making new world #15

Closed ConqAra closed 2 years ago

ConqAra commented 2 years ago

Every block you pick up is counted as it's own stack, you have to manually put them into the same stack when you pick up the blocks, definitely a bug. Could be a mod incompat as well. When I try to create a singleplayer world with the mod, it just gives me a .io netty exception and sends me back to the... multiplayer menu? Very odd. I had to actually test this on already-made worlds.

Log: https://paste.ee/p/H3dCu

Roundaround commented 2 years ago

Definitely a mod incompatibility, but I don't know with what. That's a very very long list of mods and a lot of errors in the log to sift through. It'll take some time to get through it all

andersmmg commented 2 years ago

I get the same issue, but on a fresh 1.19 instance with only this mod installed. (I haven't seen crashes yet, that seems to something else)

Roundaround commented 2 years ago

Okay, took a LOT of trial and error but I think I finally fixed it! Check out 1.2.2:

https://modrinth.com/mod/roundaround-pickup-notifications/version/1.2.2%2B1.18.2 https://modrinth.com/mod/roundaround-pickup-notifications/version/1.2.2%2B1.19

As for the crashing, I do still think it's a mod incompatibility but I haven't identified what yet. @ConqAra would you mind testing out the new version and if it still crashes, post a new issue specific to that?

andersmmg commented 2 years ago

Seems to be fixed for me too!

ConqAra commented 2 years ago

Fixed!