search

Roundaround / mc-fabric-pickup-notifications

MIT License
4 stars 0 forks source link

Using Elytra Boosters spams/breaks the notifications #21

Open ConqAra opened 2 years ago

ConqAra commented 2 years ago

Don't know why, but when turning on the elytra boosters from this mod the notifications will infinitely spam "Elytra Booster" in the popup notifications

Version: 1.18.2

Roundaround commented 2 years ago

Looking through their code it looks like they're giving the items custom NBT values every tick for the current fuel level, which triggers my code to detect "new" items every frame.

It should be possible to write a specific check for their item type and ignore the NBT value similar to how I ignore damage for normal items, though that puts a dependency on their mod for me to ever update my own to a new version.

I'm a little tired at the moment, so maybe after sleeping on it I'll get inspired with an easier fix!

Roundaround commented 2 years ago

If you feel so inclined, it may also be worth opening an issue on their repo as well, and feel free to mention this comment. If they were to find a way to get rid of the "TicksLeft" NBT value and stick to a purely damage-based durability solution like all the vanilla Minecraft items do it, that would also solve the issue.