search

Rovak / InlineAttachment

Easily paste and upload files/images in plain textareas
http://git.razko.nl/InlineAttachment
MIT License
619 stars 77 forks source link

Add customUploadHandler option #10

Closed ROMB closed 11 years ago

ROMB commented 11 years ago

This allows to handle uploads in other way, like with socket.io

Rovak commented 11 years ago

Nice patch, could you add the changes to the README.md aswell?

ROMB commented 11 years ago

Updated

micho commented 11 years ago

I :+1: the functionality, just one question:

Is this project following any kind of jslint/jshint syntax? It'd be good to unify styles, like whether it's ok to omit the space after if

micho commented 11 years ago

Related issue: https://github.com/Rovak/InlineAttachment/issues/9

Rovak commented 11 years ago

@micho the project does not enforce any syntax right now, i made a PR #11 with a new jshint checker. I could not find the option to check for a space after an if statement.

Rovak commented 11 years ago

Last issue is if returning false is the way to go, in jQuery you stop further propagation with false, i would expect that returning false would stop events instead of executing any events like the default behavior. @micho @ROMB thoughts?

ROMB commented 11 years ago

Updated to reflect last suggestion

ROMB commented 11 years ago

Now i have working realisation with socket.io. https://github.com/ROMB/corechat

Rovak commented 11 years ago

Thanks!