search

Rovak / wallet-web

Tron Protocol Wallet
https://tronscan.org
GNU Lesser General Public License v3.0
55 stars 29 forks source link

redirect to login page & list my transactions & improved TRX balance view #115

Closed lazarovicedo closed 6 years ago

lazarovicedo commented 6 years ago

If user tries to access pages reserved for logged in users, instead of showing an alert it makes more sense to show him the login page, it saves one step for the user. Send y receive links are shown only if the users is logged in. Added latest transactions for logged in user

Johnsavadkuhi commented 6 years ago

@lazarovicedo solve conflicts

lazarovicedo commented 6 years ago

@Rovak The list of user's transactions here is very limited, it only searches transactions in the last 6 blocks (just a couple of minutes ago). Having a new API function for searching transactions in all blocks will be very useful but very slow. What about exporting all transactions to a MongoDB every hour or so?

Rovak commented 6 years ago

@lazarovicedo java-tron should provide a way to query all the transactions for a given address, i believe that feature is almost done.

Rovak commented 6 years ago

the transaction page is doing 100 block requests. I'm not sure if it is a good idea to add a transaction page if it only shows the transactions for the recent x blocks. That would be really confusing when someone logs in the next day and doesn't see his transactions.

I suggest to remove the button from the account dropdown for now but keep the page in the code for when there is a way to query all transactions for an account.

lazarovicedo commented 6 years ago

done

Saludos,

Lazaro Vicedo lazarovicedo@gmail.com

2018-05-04 23:35 GMT+02:00 Roy van Kaathoven notifications@github.com:

the transaction page is doing 100 block requests. I'm not sure if it is a good idea to add a transaction page if it only shows the transactions for the recent x blocks. That would be really confusing when someone logs in the next day and doesn't see his transactions.

I suggest to remove the button from the account dropdown for now but keep the page in the code for when there is a way to query all transactions for an account.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tronprotocol/wallet-web/pull/115#issuecomment-386741461, or mute the thread https://github.com/notifications/unsubscribe-auth/AA-qwzNpEvg9z2Ff5Ws2X_w7t4PYmXzIks5tvMm6gaJpZM4TmCjI .