RoverRobotics-archive / roverrobotics_ros2

Packages for running an OpenRover robot on ROS2
30 stars 11 forks source link

adding timeout for pi controller to prevent run away #19

Closed padiln closed 3 years ago

padiln commented 3 years ago

There currently exists an issue where when a cmd_vel message is sent to the rover_driver that the message sets the pi controller target, but never reset to 0 if a cmd_vel message in never received again. This causes a runaway behavior.

This pull request solves this by adding a 1-second timer to the driver level that resets the left and right controllers unless a new cmd_vel message is received.