Roverok / libnfc

Automatically exported from code.google.com/p/libnfc
GNU Lesser General Public License v3.0
0 stars 0 forks source link

Fix build on NetBSD #63

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Just add access to a NetBSD box (remote access though so it will not be 
possible to test if libnfc 
work yet but still it is possible to ensure libnfc builds).

It doesent because of some serial speeds not defined unless _NETBSD_SOURCE is.  
The patch 
bellow adds some compilation sanity checks but maybe we should discuss how we 
can have 
something that is generic here since each OS seems to have it's own "Standard 
speeds".   think 
we should either add a macro that checks if a macro speed is defined and add 
according code if 
so, or do not use macros at all.

What do you think ?

Index: src/lib/buses/uart.c
===================================================================
--- src/lib/buses/uart.c        (revision 294)
+++ src/lib/buses/uart.c        (working copy)
@@ -117,12 +117,18 @@
     break;
     case 38400: stPortSpeed = B38400;
     break;
+#ifdef B57600
     case 57600: stPortSpeed = B57600;
     break;
+#endif
+#ifdef B115200
     case 115200: stPortSpeed = B115200;
     break;
+#endif
+#ifdef B230400
     case 230400: stPortSpeed = B230400;
     break;
+#endif
 #ifdef B460800
     case 460800: stPortSpeed = B460800;
     break;
@@ -155,12 +161,18 @@
     break;
     case B38400: uiPortSpeed = 38400;
     break;
+#ifdef B57600
     case B57600: uiPortSpeed = 57600;
     break;
+#endif
+#ifdef B115200
     case B115200: uiPortSpeed = 115200;
     break;
+#endif
+#ifdef B230400
     case B230400: uiPortSpeed = 230400;
     break;
+#endif
 #ifdef B460800
     case B460800: uiPortSpeed = 460800;
     break;

Original issue reported on code.google.com by romain.t...@gmail.com on 5 Feb 2010 at 1:31

GoogleCodeExporter commented 9 years ago
Thanks Romain.
I close this issue since you have fixed it in r298 and r306.
BTW, you now can use libnfc 1.3.3 stable release.

Original comment by romu...@libnfc.org on 17 Feb 2010 at 5:00