binutils functions without prototype

[GoogleCodeExporter]

bitutils.c:81: warning: no previous prototype for ‘oddparity_bytes’
bitutils.c:97: warning: no previous prototype for ‘mirror_bytes’
bitutils.c:132: warning: no previous prototype for ‘iso14443a_crc’

I added the missing declarations in libnfc/bitutils.h.
iso14443a_crc() is already declared in include/nfc/nfc.h so I just added a
#include in libnfc/bitutils.c

Proposed patch:
Index: libnfc/bitutils.c
===================================================================
--- libnfc/bitutils.c   (revision 389)
+++ libnfc/bitutils.c   (working copy)
@@ -29,6 +29,7 @@
 #include <stdio.h>

 #include "bitutils.h"
+#include "nfc/nfc.h"

 static const byte_t OddParity[256] = {
   1, 0, 0, 1, 0, 1, 1, 0, 0, 1, 1, 0, 1, 0, 0, 1,

Index: libnfc/bitutils.h
===================================================================
--- libnfc/bitutils.h   (revision 389)
+++ libnfc/bitutils.h   (working copy)
@@ -49,9 +49,11 @@
 #include <nfc/nfc-types.h>

 byte_t oddparity(const byte_t bt);
+void oddparity_bytes(const byte_t* pbtData, const size_t szLen, byte_t*
pbtPar);
 void oddparity_byte_ts(const byte_t* pbtData, const size_t szLen, byte_t*
pbtPar);

 NFC_EXPORT byte_t mirror(byte_t bt);
+NFC_EXPORT void mirror_bytes(byte_t *pbts, size_t szLen);
 NFC_EXPORT uint32_t mirror32(uint32_t ui32Bits);
 NFC_EXPORT uint64_t mirror64(uint64_t ui64Bits);
 NFC_EXPORT void mirror_byte_ts(byte_t *pbts, size_t szLen);

Original issue reported on code.google.com by ludovic....@gmail.com on 17 Apr 2010 at 10:00

[GoogleCodeExporter]

Thanks. Fixed in r398.

Original comment by romu...@libnfc.org on 20 Apr 2010 at 9:44

• Changed state: Fixed
• Added labels: Priority-Low
• Removed labels: Priority-Medium