Roverok / libnfc

Automatically exported from code.google.com/p/libnfc
GNU Lesser General Public License v3.0
0 stars 0 forks source link

examples/nfc-mfultralight.c: warning: no previous prototype for ... #77

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
nfc-mfultralight.c:50: warning: no previous prototype for
‘print_success_or_failure’
nfc-mfultralight.c:57: warning: function declaration isn’t a prototype
nfc-mfultralight.c: In function ‘read_card’:
nfc-mfultralight.c:57: warning: old-style function definition
nfc-mfultralight.c: At top level:
nfc-mfultralight.c:94: warning: function declaration isn’t a prototype
nfc-mfultralight.c: In function ‘write_card’:
nfc-mfultralight.c:94: warning: old-style function definition

Proposed patch:
Index: examples/nfc-mfultralight.c
===================================================================
--- examples/nfc-mfultralight.c (revision 389)
+++ examples/nfc-mfultralight.c (working copy)
@@ -46,14 +46,14 @@
 static mifareul_tag mtDump;
 static uint32_t uiBlocks = 0xF;

-void print_success_or_failure(bool bFailure, uint32_t* uiBlockCounter)
+static void print_success_or_failure(bool bFailure, uint32_t* uiBlockCounter)
 {
   printf("%c",(bFailure)?'x':'.');
   if (uiBlockCounter)
     *uiBlockCounter += (bFailure)?0:1;
 }

-bool read_card()
+static bool read_card(void)
 {
   uint32_t page;
   bool bFailure = false;
@@ -90,7 +90,7 @@
   return (!bFailure);
 }

-bool write_card()
+static bool write_card(void)
 {
   uint32_t uiBlock = 0;
   int page;

Original issue reported on code.google.com by ludovic....@gmail.com on 17 Apr 2010 at 10:13

GoogleCodeExporter commented 9 years ago
Thanks. Fixed in r397.

Original comment by romu...@libnfc.org on 20 Apr 2010 at 9:28