Rowdy-Avocado / Rowdycado-Extensions

34 stars 8 forks source link

Subtitle parsing issue in CodeStream provider #10

Open stojkovskistefan opened 2 months ago

stojkovskistefan commented 2 months ago

There's a critical issue with subtitle parsing in the CodeStream provider. The problem stems from a mismatch between the expected structure of the subtitle data and the actual structure provided by the API. This issue is causing subtitles to be incorrectly parsed or not parsed at all.

Current behavior - Here is a picture: image

Actual API response: The API is actually providing subtitle data in this format:

"subtitles": [
  {
    "url": "https://cc.2cdns.com/d6/20/d62068ec491a43de9fc34e18b5dcdcfb/eng-3.vtt",
    "lang": "English - English (SDH)"
  },
  ...
]

Expected behavior: The code should correctly parse and use the subtitle information provided by the API.

Proposed fix: Update the subtitle parsing code to match the actual API response.

Steps to reproduce:

  1. Attempt to load subtitles for any media in the CodeStream provider
  2. Observe that subtitles are not correctly loaded or parsed

Potential impact: This issue affects all users of the CodeStream provider, preventing them from accessing subtitles for their media.

By addressing this issue, we can ensure that subtitles are correctly parsed and available to users of the CodeStream provider. This fix would also bring the CodeStream provider in line with the expected behavior described in the linked issue, contributing to a more consistent subtitle handling across the entire application.

stojkovskistefan commented 2 months ago

image also some issues came up right now...

stojkovskistefan commented 2 months ago

@RowdyRushya @AvocadoWasSeized