Buildkite will now set up a Go environment in the Buildkite build folders, it will build the server, run tests and run linters. go vet errors will cause the tests to fail, since they can be critical errors in the server code. The golint code style checks will not for now, though. The server code style guide does not work well with the standard Go style guide, this will be updated in the future but needs some refactoring. I also fixed some errors in our code found by go vet in this PR, so that CI succeeds. Will squash and merge if you approve.
datwelk
commented
8 years ago
Buildkite will now set up a Go environment in the Buildkite build folders, it will build the server, run tests and run linters.
go veterrors will cause the tests to fail, since they can be critical errors in the server code. Thegolintcode style checks will not for now, though. The server code style guide does not work well with the standard Go style guide, this will be updated in the future but needs some refactoring. I also fixed some errors in our code found bygo vetin this PR, so that CI succeeds. Will squash and merge if you approve.@datwelk @sander-m