search

Roxxers / roxbot

Roxbot: An inclusive modular multi-purpose Discord bot. Built with love (and discord.py)
MIT License
21 stars 5 forks source link

Non Horizontal Pride Flags #59

Open MxSummerNight opened 5 years ago

MxSummerNight commented 5 years ago

There are a tonne of pride flags out there and not every one of them feature only horizontal stripes currently doable in the pride command. A rewrite of the cog to accept .svgs and apply those over top of the supplied image would be ideal: it could even be set to read a config file to get the aliases for a flag and have less duplicated code; searching the config for the specified arg instead of a sub-command and using that filter instead of hardcoded stuff. I'd mess around and see if i could get it working myself but very away from pc atm.

Roxxers commented 5 years ago

The reason for the subcommands is to provide better documentation. It allows it to split up each flag and provide aliases that can be easily accessed via ;help.

I don't think it's the smartest idea to allow users to upload their own images for use when it comes to potential security issues that coils happen due to that. It's also not user friendly and of a user has the svg for a pride flag it wouldn't be hard for them to open up gimp themselves and apply the overlay.

I feel its better to hardcode this for the ease of use and just keep expanding on the command group when requested.