search

Roxxers / roxbot

Roxbot: An inclusive modular multi-purpose Discord bot. Built with love (and discord.py)
MIT License
21 stars 5 forks source link

partner rating 'improvment!?' #8

Closed TBTerra closed 6 years ago

TBTerra commented 6 years ago

Rating system is now deterministic. it is also order independant meaning that A rate B will result in the same value as B rate A, and that poly ratings wont care about mention order.

This system does have draw backs. most notably that if somone dosnt like the rating they got, they cant run it again to get a better rating.

Its upto you if you think adding this to the bot would be an improvment. I just did it for fun.

PS. havent tested on actual server so the way i grab mention userIDs on lines 218-220 might be wrong

valknight commented 6 years ago

a pull request? in roxbot?

what is this

in all seriousness tho, I'm out at the moment, but from what I can see, seems pretty good - only thing is you could always add an argument to revert to old style ranking, just incase, but that's probably a bit too far for what is a joke command

valknight commented 6 years ago

(also lmao sorry for jumping in here, we have github on webhook, and I checked to see what roxie was upto)

Roxxers commented 6 years ago

While basing rating of paring is cool, I wouldn't want this command to be so complicated. I'm hesitant to pull for a number of reasons to begin with. But one major one is that hashing the IDs when discord themselves only use discriminators for things like determining default avatar colour. This is too complicated and a similar result can be done with less code.

Roxxers commented 6 years ago

I just think it's too complex for a simple command. If it can be made more simple I'll accept it.