Visitor framework is restrictive

GoogleCodeExporter commented 9 years ago

I am trying to use the expression visitor framework to generate SQL queries for 
Teiid (http://teiid.org), and I see that the visitor framework defined on the 
expression language objects is not flexible, I am finding it very hard to use 
it for my purpose.

The visit method is doing couple different things

1) visit itself
2) also dictating how the language object needs to be traversed

Good example is "BinaryCommonExpressionImpl", it defines all the object 
traversal in the visit method. IMO, these two should be separated into two 
separate concerns.

https://code.google.com/r/rareddy9-teiid/source/detail?r=d1d01dc6164a3cf9fb03c09
e9e296ee7c9633ba5

In this patch, which also includes the Issue 228, I have provided visitor 
framework with above concerns separated.

Original issue reported on code.google.com by rared...@gmail.com on 7 Jan 2013 at 4:31

GoogleCodeExporter commented 9 years ago

I meant Issue 238 not 228 as defined above.

Original comment by rared...@gmail.com on 7 Jan 2013 at 4:33

GoogleCodeExporter commented 9 years ago

Fixed as part of Ramesh's change e4fc8039410417def65089c6a02d6ed3b5e9f5b6

Original comment by john.spurlock on 14 Apr 2013 at 4:05

Changed state: Fixed

RoyZeng / odata4j

Visitor framework is restrictive #239