Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards
https://storybook.design-system.navy.digital.mod.uk
Apache License 2.0
103 stars 32 forks source link

ci(Sonar): Testing sonarcloud #1912

Closed elglup closed 3 years ago

elglup commented 3 years ago

Related issue

closes #1715

Overview

Trying Sonarcloud

Reason

[Why did you do what you did? - feel free to copy from the ticket if the reason is there]

Work carried out

[A list of work you have done, use markdown checklist format, if you leave any boxes unchecked, be sure to set this PR as a WIP]

Example.

Screenshot

[If the work is UI related then paste a screenshot of the update here.]

Developer notes

[Sometimes, extra notes are needed to add clarity to a PR, add them here]

codecov[bot] commented 3 years ago

Codecov Report

Merging #1912 (ef63ff9) into master (8936141) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1912   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files         408      408           
  Lines        2714     2714           
  Branches      689      689           
=======================================
  Hits         2652     2652           
  Misses         62       62           
sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

codeclimate[bot] commented 3 years ago

Code Climate has analyzed commit ef63ff9a and detected 0 issues on this pull request.

View more on Code Climate.

m7kvqbe1 commented 3 years ago

Is this now ready for review?

elglup commented 3 years ago

Is this now ready for review?

No not yet, need to apply a number of changes picked up during testing. Will probably close this draft PR & create a fresh one when ready

elglup commented 3 years ago

Closing draft PR as used for testing only. Will open a new PR for implementation.