Closed m7kvqbe1 closed 2 years ago
Thanks @m7kvqbe1, looking great! Minor style tweaks:
When at the lowest / highest value, the handle should be mid-aligned to the visual start / end of the scale. It's currently a few pixels off:
Clicking anywhere on the slider (causing the handle to move) or grabbing and moving the number input box should cause the slider handle to get the focus. Currently it only gets the focus if I grab the handle itself or tab to it.
Clicking exactly on a tickmark doesn't cause the slider to move there (notice the second click in the video above).
Apologies this wasn't called out in the spec, but can you ensure a 12px padding between the icons and the edges of the slider track please?
@m7kvqbe1 FYI the Chromatic build failed for IE11:
Removed CSS variables optimization because IE11 polyfills do not work with styled-components.
Thanks for the fixes @m7kvqbe1 - looking great! 👍
I assume this is part of #2849 but just so it doesn't get lost:
Tickmarks with thresholds currently disappear behind the filled track. Current: Spec:
All earlier points have been addressed, thank you! :)
SonarCloud Quality Gate failed.
Related issue
Closes #2436
Overview
Create new experimental
RangeSliderE
component based on design spec.Link to preview
https://61a8f4b587ed053ee108b405--rangeslidere.netlify.app
Reason
Work carried out
hasMarkers
prop to toggle markershasPercentage
featureScreenshot
Developer notes
The design spec changes the way threshold functionality works when combined with multiple handles.
Needs discussion with design authority to elaborate on desired behaviour.
This will be implemented as part of a seperate PR: https://github.com/defencedigital/mod-uk-design-system/issues/2849