search

Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards
https://storybook.design-system.navy.digital.mod.uk
Apache License 2.0
103 stars 32 forks source link

DatePicker - Warning: findDOMNode is deprecated in StrictMode #3528

Open thyhjwb6 opened 1 year ago

thyhjwb6 commented 1 year ago

Steps to reproduce

  1. Create a new application using the CRA template
  2. Add DatePicker inside React.StrictMode
  3. Start application
  4. Open DatePicker sheet and view the console

Screenshot

Screenshot 2022-11-25 at 16 05 05
jpveooys commented 1 year ago

Hi @thyhjwb6 :wave:

There was a fix for this in version 9.0.0 or newer of focus-trap-react: https://github.com/focus-trap/focus-trap-react/issues/77

However, we're unable to update at the moment as it would break support for older browsers (which would be a breaking change).

github-actions[bot] commented 1 year ago

This issue has been marked as stale because it has been open for 60 days with no activity

oliverrees commented 6 months ago

+1 for this issue!

github-actions[bot] commented 4 months ago

This issue has been marked as stale because it has been open for 60 days with no activity

markhigham commented 1 month ago

Revisiting this as legacy browser support requirements have changed