search

Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards
https://storybook.design-system.navy.digital.mod.uk
Apache License 2.0
103 stars 32 forks source link

Sortable table appears with a line break #3713

Closed oliverrees closed 1 month ago

oliverrees commented 4 months ago

The sortable table component is meant to look like the below (as specified in storybook).

Screenshot 2024-01-15 at 15 16 11

However, when you use a vanilla installed version of the design system and copy and paste the code example, the table headings appear with a line break between the text and the sorting arrows (see below)

Screenshot 2024-01-15 at 15 14 55

To reproduce:

  1. Start with a vanilla version of the design system (I'm using create-next-app)
  2. Copy and paste the storybook example from above
github-actions[bot] commented 2 months ago

This issue has been marked as stale because it has been open for 60 days with no activity

m7kvqbe1 commented 2 months ago

I wonder if there are some global styles or style bleed causing this?

We haven't been able to reproduce it ourselves. Are you able to create a minimal reproduction for us?

Note we are currently implementing a DataGrid that will have feature parity with the table and is intended to supersede it.

m7kvqbe1 commented 1 month ago

We've just shipped the new DataGrid and deprecated Table.

Please consider upgrading to that.