Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards
https://storybook.design-system.navy.digital.mod.uk
Apache License 2.0
103 stars 32 forks source link

feat(Alert): Allow arbitrary content in Alert #3740

Closed markhigham closed 1 month ago

markhigham commented 1 month ago

Related issue

3734

Overview

Changed children props of Alert component from string to ReactNode and changed container element from <p> to <div>

Reason

This allows Design System users to include arbitrary html in their alerts.

Work carried out

Screenshot

image
netlify[bot] commented 1 month ago

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
Latest commit f98764521f4d98284a76dca94f24d328c93bdcce
Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/660c0037a477fb00089068b6
Deploy Preview https://deploy-preview-3740--storybook-navy-digital-mod-uk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud