Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards

https://storybook.design-system.navy.digital.mod.uk

Apache License 2.0

103 stars 32 forks source link

fix(List): Allow arbitrary contents in List Item #3741

Closed markhigham closed 1 month ago

markhigham commented 1 month ago

Related issue

3682

Overview

Change to ListItem props to allow arbitrary contents.

Reason

Taken from the Issue

Accoring to the ListItem documentation a ListItem should accept (string | string[]) & ReactNode as children. However, in the Type definition only string | string[] are allowed, dramatically reducing the customisation possible in a ListItem

Work carried out

[x] Change ListItem props to accept ReactNode
[x] Unit tests
[x] Update to storybook

Screenshot

netlify[bot] commented 1 month ago

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name	Link
Latest commit	697f6c3203940707bd3e4755c4226d7e465acae8
Latest deploy log	https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/660d19a66b78490008d7afea
Deploy Preview	https://deploy-preview-3741--storybook-navy-digital-mod-uk.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.