search

Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards
https://storybook.design-system.navy.digital.mod.uk
Apache License 2.0
103 stars 32 forks source link

feat(Masthead): Add inline nav for masthead #3744

Closed markhigham closed 1 month ago

markhigham commented 1 month ago

Related issue

Closes #3743

Overview

Extend the Masthead component to render the MastheadNav inline. Use a new prop inlineNav: boolean

Reason

To align the DS component with in the field implementations. To provide more vertical screen space as requested by downstream consumers.

Work carried out

Screenshot

image
netlify[bot] commented 1 month ago

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
Latest commit a4ae5be554253f9354169a6b4e12387f49a87f60
Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/66180ac031a32d0008b9e30e
Deploy Preview https://deploy-preview-3744--storybook-navy-digital-mod-uk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

markhigham commented 1 month ago

Change margin for banner to padding so that bottom border extends the full screen width. Change to prop name from inlineNav to hasInlineNav

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud