Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards
https://storybook.design-system.navy.digital.mod.uk
Apache License 2.0
103 stars 32 forks source link

test(Chromatic): Resolve broken Chromatic PR status reporting #3771

Closed m7kvqbe1 closed 2 weeks ago

m7kvqbe1 commented 2 weeks ago

Related issue

Closes #3765

Overview

Chromatic now correctly reports status in Pull Requests.

Reason

Chromatic was not reporting status within PRs and as such would not block merges when diffs existed.

Work carried out

Screenshot

Screenshot 2024-04-30 at 10 29 16

Developer notes

Org level OAuth scopes are a bit of a gotcha.

If they've not been explicitly granted then Chromatic will just fail status reporting silently.

netlify[bot] commented 2 weeks ago

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
Latest commit 9cd26da72771ba1c4cec9eadc013fa0b31b2adeb
Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/6630b5115715220008f64c48
Deploy Preview https://deploy-preview-3771--storybook-navy-digital-mod-uk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud