Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards
https://storybook.design-system.navy.digital.mod.uk
Apache License 2.0
103 stars 32 forks source link

fix(ProgressIndicator): Avoid downstream runtime warning from Next.js #3772

Closed m7kvqbe1 closed 2 weeks ago

m7kvqbe1 commented 2 weeks ago

Related issue

Closes #3714

Overview

Apply via css property in keyframe definition to avoid inline transform-origin upon on transpilation.

Reason

Next.js is wrongly throwing a runtime warning about the transform-origin SVG attribute.

This is a valid HTML SVG attribute.

Work carried out

Screenshot

Screenshot 2024-04-30 at 11 57 14

Developer notes

https://github.com/vercel/next.js/issues/53342#issuecomment-2084923492

https://github.com/facebook/react/pull/26130/files#diff-67b481b96d526280780f010dfd192761f2d1f6dc812e3015020a7986501d2ebaR524

netlify[bot] commented 2 weeks ago

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
Latest commit b287d4239cc90e37f5758f3a612541e69f7aca83
Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/66321f46e1617f00086997a4
Deploy Preview https://deploy-preview-3772--storybook-navy-digital-mod-uk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud