fix(Lerna): Resolve Pnpm and Lerna version issue

Royal-Navy / design-system

Build web applications that meet the Royal Navy service standards

https://storybook.design-system.navy.digital.mod.uk

Apache License 2.0

103 stars 32 forks source link

fix(Lerna): Resolve Pnpm and Lerna version issue #3799

Closed m7kvqbe1 closed 2 weeks ago

m7kvqbe1 commented 2 weeks ago

Overview

Resolve broken release workflow.

Pnpm was not respecting local versions of monorepo packages and flagging that the incremented version did not exist (because it hadn't yet been published):

https://github.com/Royal-Navy/design-system/actions/runs/9094408002/job/24995417211

Screenshot 2024-05-15 at 12 47 45

https://pnpm.io/npmrc#link-workspace-packages

If this is enabled, locally available packages are linked to node_modules instead of being downloaded from the registry. This is very convenient in a monorepo. If you need local packages to also be linked to subdependencies, you can use the deep setting.

netlify[bot] commented 2 weeks ago

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name	Link
Latest commit	6ed52620ad467c7af6e862adb29bfe7da5f9545f
Latest deploy log	https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/6644a1020158e00009cebf73
Deploy Preview	https://deploy-preview-3799--storybook-navy-digital-mod-uk.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.