Fix for #1270 (Do Not Merge)

Royal-Society-of-New-Zealand / NZ-ORCID-Hub

The home of development for the New Zealand ORCID Hub

MIT License

13 stars 8 forks source link

Fix for #1270 (Do Not Merge) #1273

Closed rpaw053 closed 4 years ago

rpaw053 commented 4 years ago

I have done the changes as per https://github.com/Royal-Society-of-New-Zealand/NZ-ORCID-Hub/issues/1270

Removed url from compulsory fields both in file upload and on form, however if user doesn't specify url then ORCID call will still fail because of issue on ORCID side.

Till the bug is fixed at ORCID end, the user will have to specify url

rpaw053 commented 4 years ago

from Jason: Turns out url is the canonical required field (tho not specified in either xsd or swagger : https://github.com/ORCID/ORCID-Source/blob/master/orcid-api-web/tutorial/personal_identifiers.md As a consequence, shouldn't be merged unless there's a surprise and ORCID changes the model.