RoyalBingBong / meView

Image Viewer that also allows playback of webm and mp4
ISC License
33 stars 9 forks source link

Changed style to a flat and dark theme #7

Closed Hammster closed 6 years ago

Hammster commented 7 years ago

Hey there,

First of all, I really like your image viewer, exactly what I needed 👍 But I really disliked the contrast of the application and so I changed the UI to suit my needs and preferences (quick and dirty). The outcome looked like a good concept, while not being polished. I pushed the changes to my fork. If you want to integrate this properly just tell me, naturally I'm open to changes. 😉

Generally, the reason behind this change is:

RoyalBingBong commented 7 years ago

Sorry for the late reply. I like the changes you made, but will not merge it (for now). I have a bit of a problem with dark themes in general, because the low contrast is a real problem for my eyes.

But your pull request is a nice incentive to look into switchable themes and to work on meView again.

Hammster commented 7 years ago

No worries, I think allowing the user for changing some styles is a great idea. Especially since everyone has his own taste. It does not really need to be fully customizable though, a switch between dark and bright should cover most cases and if that works a custom style feature is probably just a matter of exchanging a stylesheet.

RoyalBingBong commented 6 years ago

Closing, because new version has a dark and a light theme, plus the user can creat his own theme.