search

RoyalHaskoningDHV / sam

Python package for time series analysis and machine learning
MIT License
26 stars 6 forks source link

Updated wrong types in `quantile_plot.py` #72

Closed miguelpher closed 1 year ago

miguelpher commented 1 year ago

Type for y_true was set to pd.DataFrame, while a few lines later in sam_quantile_plot, y_true.name is checked. This caused the function to break, since pd.Dataframe has no attribute name, but pd.Series does. Since y_true was supposed to be a DataFrame with 1 column, this change is backwards compatible when y_titleis provided.

rubenpeters91 commented 1 year ago

This makes sense, though we could also use the squeeze function to optionally squeeze a dataframe into a series. But that't maybe a task for later, for now this will suffice