search

RoyaleAPI / cr-api-data

Clash Royale API Static data and constants.
http://RoyaleAPI.com
42 stars 23 forks source link

Encoding not defined to open csv file #3

Closed MrFiregore closed 6 years ago

MrFiregore commented 6 years ago

In the file cr/base.py line 87 you forgot to put the type of encoding Old: with open(csv_path) as f:

New: with open(csv_path, encoding="utf8") as f:

fourjr commented 6 years ago

you can pr that

smlbiobot commented 6 years ago

well I’m gonna fix this quickly but yes please PR this in the future

smlbiobot commented 6 years ago

The thing with this repo is that if @fourjr is really using this to get real-time constants — and somebody screwed up somewhere while I can’t really see it in the feed it can really screw people over — e.g. it is really hard to see what has changed even with diff — because how would I know if the update is not in fact the right one.

smlbiobot commented 6 years ago

there — added but clearly nothing is changed in the output…