Aggregate list of ijm8710 issues

[ijm8710]

Will adjust accordingly with your updates

A. Quick patches

1. [x] Clan league badge on bottom analytics table (at least on mobile) needs to move one tile to the right [#316]
2. [ ] Fix sorts for log: Missed war battlers at bottom; Players with same collection score should secondarily sort missed collections to bottom [#314]
3. [ ] Inconsistent win% between clan average (omits misses) and player average on the analytics table.
4. [ ] Per #341, vertically sorting top analytics table on a specific date does not properly sort missed war attacks.
5. [x] On mobile, if I go to bottom analytics table and turn the toggle off, the top table will update, but the toggle will not reflect that (out-of-sync) [#320]

B. Intermediary requests

1. [ ] Show collection battles played fraction going forward for Clan war history boxes [#316]
2. [ ] Clan average bar for analytics table should fill in count and MIA boxes to reflect trending average clan participation and activity over last 10 [#317]

C. TBD requests

1. [ ] Player snapshot screen when clicking on Player-ID to show trophy high, clan-role, king tower level, lifetime win % (expanded on ticket #296) [#315]
2. [ ] Analytics table should reflect # of participants in each individual war and the trending average as well. [#317]
3. [ ] Number the analytics table down and/or show a (count) next to the filter of total current members only. [#317]
4. [ ] Looking for list of players in clan for analytics table who have not participated in last 10 wars [#243]
5. [ ] AdjustUTC dates per time-zone
6. [ ] Provide Summary statistics to show ‘lifetime war stats’: [#315]
   • wars won
   • total wars
   • missed final battles
   • total cards and/or avg. cards collected
   • average collections played

D. Long term TBD

1. [x] Mobile app (no update needed, just aggregating it here as something I eventually hope for :) )

Thank you for implementations thus far

[ijm8710]

@Smlbiobot, this is ready for your review. Hopefully this is easier. Thanks!

[ijm8710]

For the 7th item in section 3, if this is something you are unwilling to do, a lot of the tallies would be done manually. If this remains the case, please add a separate shade-color for “lost all” similar to how you differentiate “won” and “won all”

[smlbiobot]

You want to know why there is no comment. We have our own priorities. You have so many issues that I have hired an executive assistant to read through all your issues so that they could be compiled into a manageable list.

While your issues sit here, I have other high priority items that I need to work on. Reviewing your issues is taking more time than necessary. If I can’t comprehend within seconds what need to be done, I fix other tasks that I have a clear idea of what’s happening first.

[ijm8710]

Then don’t ask me to make this! I spent a couple hours putting this together per YOUR ask! Each ticket does take seconds to read. They are all concise as you requested. The only reason there are so many is for some reason you have some issue with me and ignore 60% of what I put out. Literally it’d prob take 15 minutes to read the entire post and briefly annotate a response and you’ve basically confirmed what I’ve been saying, that the post you ASKED me to put together has been intentionally ignored. Seriously this makes no sense. Take your time, but it’s been sitting there for 40+ days, show some respect for users who you have asked to direct comments to github the same way I have showed complete reverence towards a great product that can only improve. If everything I’m saying is off topic-ban me. But I think it’s fair to say each of those comments are extremely on-topic and You yes you havee chosen to let them acclimate.

[smlbiobot]

I did ask for a list. I also ask that they be concise. Let me help you with what concise means. Take this example:

Per your last comment in #315, you adjusted win% consistencies. There’s still an inconsistency for the win% on the clan average bar on the analytics table using the alternative logic.

It would be far better to say:

• Inconsistent win% on clan average bar on analytics table

That is readable, concise. Now you can use the space to describe the problem.

[smlbiobot]

No one can read this in less than 3 seconds to know what it means:

Number the analytics table down and/or show a (count) next to the filter of total current members only. This will allow you to know how many active people have had participation in the clan. If my clan has 49 current members. And 47 current members are showing here. I know there are 2 members I need to review who are completely inactive over last 10 wars.

Tasks need to short. Do you do to-do lists? Do you write a whole paragraph to your to-do list? Of course you don’t. You put in 2-3 words to describe the item so you can get them done.

• You don’t write: “Get milk so I can use it for my next birthday cake”
• You would write: “milk”. Or maybe “milk for cake”

[ijm8710]

Ok thank you. As I said I’m not being hostile. I will readjust those comments and readjust any relating comments to be concise. I’m trying to be proactive . Thanks for the actual good feedback 👌

[ijm8710]

Updated.

[smlbiobot]

Please make to-do lists as to-do list, like this:

• [ ] item one
• [ ] item two

Also make them action- based.

instead of

UTC dates adjusting for the browser per time-zone

• [ ] Adjust UTC dates per timezone

Not saying that we will do it necessarily. The thing about these is that when someone download the CSV the time will be off, so it is in fact better to use UTC dates so they align with the CSV data.

But all these gerunds make things impossible to read.

[ijm8710]

Done

[smlbiobot]

Add space between [ ] and word

[ijm8710]

Sure

[ijm8710]

@smlbiobot last tag for today and I appreciate you and your activeness today. Can you try to attempt to glance at these some point in the next month? Perhaps I can provide more info if necessary or remove some but I am assuming at least a few would be semi-quick adjustments like the sorts.

[ijm8710]

@smlbiobot while some of these are feature requests, some of these are in fact legit bugs. A3 I’m certain is an actual inconsistency. Perhaps you want that inconsistency there but isn’t that the point of GitHub, to post it and get a quick comment on it or perhaps even tweak it if the comment is legitimate?

all I’m asking for is if you can give this a look in the next few months. Not, do it now. But a simple, I’ll try or not when you can. It’s been over 3 months and I refined them again and again as you requested. These were aggregated as you requested as well.

[6Sean]

While you've done a good job consolidating small tweaks, these are mostly relatively small changes that would be prioritized low and I think that's part of your frustration. I'm working to align the work that needs to be done to help prioritize, but there are several awesome things in the works right now that need to take priority.

I would include some of these in that list. Others, like the UTC request is already implemented in a good way for a global site.

_{Sent with GitHawk}

[ijm8710]

Thanks for reply @6Sean. Much appreciate you reviewing and commenting on this!

If I had to pick three items that would most like to see, they would be:

• C6 (just something to numerically summarize the clan war history info)
• B1 (historical collection-day participation rate is something that leaves a little bit to be desired)
• C3 (simple count-metric of who’s on table)

Would you agree on any or several of those being those of merit for the mid-priority list?

Two other quick comments:

• I’m ok with everything else being lower priority! Would you agree, though, most of other items in section A are super quick adjustments? They’re just re-sorts on inconsistencies.
• Looks like you marked and fixed A5, thank you! D1 was also ticked off, of course the site is mobile optimized, but is there some app already that I’m not aware of? Completely OK with it being a super-low priority-ask, but potentially down the road even a simple wrapper of the site would be nice to have.

[6Sean]

My comments on your three primary items C6 - Sure: lifetime stats are interesting. I'm looking across the board at those asks to summarize since it's a frequently duplicated request. I also want to make sure that everyone's aware that those are much more costly -- it may become cost ineffective to expand this too much.

B1 - Maybe: not a terrible idea, but you can also discern their collection performance/activity by looking at their overall cards collected. Lower collections would generally be a sign that you're not performing well (or fully). Also, if we just highlight the collections with 2 or less games played, wouldn't that along with cards collected be enough to make a decision on the player in most cases? What's the benefit of showing it as a fraction when it's implied?

C3 - Sure: I don't see any issue with adding member counts in the total and per war if that's reasonable from a development standpoint. Seeing your count of current members on that page seems less important than how many members participated in each war. I'm not sure this could ever be a percentage, as I don't believe the API tracks # of players in-clan, but not in-war and there are other scenarios that could cause an issue there... but as an absolute number of players that participated in war, I think that's simple enough and could be valuable.

On your other comments: Missed wars (A2, A3, A4) is a data issue -- without knowing the full details, but having seen the data, I think that page is already very cleverly developed and you would need some additional logic applied (and potentially another data column calculated).

D1 - I marked it as complete because it just doesn't belong in this list. I'm sure there are quite a few people that would like a mobile app to be developed. I'm not sure that we need to open a GitHub issue for that as it's a major undertaking/project that would be prioritized (like some of the other large developments going on that aren't listed here!).

[ijm8710]

C6- cool simply a fraction or table that shows only when the clan war history section is expanded would be enough.

B1-it’s shown on analytics table for only last 10. This ask is for a lifetime view like you do lifetime for battle-day in clan war history. Lifetime is helpful to judge if poor performance is a temporary or consistent trend and also for judging potential new members.

C3-we agree showing as absolute number per war is helpful. The reason I mentioned showing the absolute number for the entire table as whole is it’s used as a reference for how many players have fully skipped wars fully over last 10. Example, 49 current members in clan, 46 on table mean 3 are fully inactive or new.

A2-A4 correct nothing new being asked, just some simple logic tweaks. Fine with low priority but I do think they’re semi quick

Thanks

[ijm8710]

Ps thanks for digging into this and cleaning things up @6Sean ; @smlbiobot he did a good job👌

[ijm8710]

Hi any update on any of these? I understand/respect that RLS has been the main priority/focus for much of 2019 and seems to have been a big hit!

At same time, there are a few things that really would make the use of royaleapi as a stat-site even more helpful. I understand not every request can be accommodated, I tried hitting on my 3 biggest and was hopeful perhaps one/a few might be doable eventually.

My biggest 3 are still the same as before:

• B1: a lifetime collection rate similar to what you have for lifetime war win-rate
• C3: a simple count of the analytics table for members on there and/or a section for members unlisted. It’s basically a way for me to see “these X members have not done war within the last 10 wars (inactive)”
• C6: expansion of lifetime stats (at least those tracked) across the board for whatever data you already have collected. Basically would love summary #s! (Example: I see this person has red/misses but they have missed wars how often either as a % or fraction that way when I quote in clan chat that a member consistently misses I have a quantitative metric behind it as opposed to just saying you do it “a lot” or having to manually count)

[ijm8710]

@smlbiobot or @6Sean are any of these 3 potentially on the roadmap for the calendar year. All already have the data built. Do you see value in any?