search

RoyaleAPI / cr-api-ux

User Experience and content issue tracker for RoyaleAPI website.
https://royaleapi.com
22 stars 16 forks source link

Clan Wars 2 - River Race TAB Bugs + feature request #550

Closed Sabbs666 closed 3 years ago

Sabbs666 commented 4 years ago

Describe the bug

The data you show is not valid:

  1. The War Trophies didn't change after the first week on War/River Race TAB(in the table showing all 5 Clans)
  2. The War Shields didn't change - some Clans are in lower War Leagues after the first week! And in your api they are all in the same League - according to the colour and shape of the War shields.
  3. The participants of the War are shown wrong - many of them didn't fight in the war (some of them only came and left - but they did both those things after the war was finished)

FEATURE REQUEST:

To Reproduce Steps to reproduce the behavior:

  1. Go to any Clan's War / RIver Race TAB

Screenshots 2020-09-08_02h59_18

Additional context Please let me know if it helped and if you'll consider my feature request :) Regards, Peter

smlbiobot commented 4 years ago
smlbiobot commented 4 years ago
smlbiobot commented 4 years ago

Contribution, which is the sum of boat repair and fame points, is now live.

cw2-participant-contributions

Sabbs666 commented 4 years ago

Clan Trophy - but you have the right values at the top of the page - so you can get it form somewhere. I'd *** (no right word) Supercell in this matter, if they do not respond :) Sum of Values *- I love you guys for adding it so quickly - You are THE BEST :)

Sabbs666 commented 4 years ago

Participants - yes you are right , they got it wrong, it's a mess - hope they correct it :) War Shield - once again - in some places they have it right (hope they will feed you with right data soon) :)

wt., 8 wrz 2020 o 11:06 SML notifications@github.com napisał(a):

  • Participants. These are values reported by Supercell also and so we report the same thing.
  • War Shield. Similar to Clan War Trophy, we use the values reported by Supercell. If I try to fetch from the clan info then I will need to make 5 for connections per clan to Supercell servers. I am not entirely sure if I should do that or wait til they fix their data. Makes sense?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RoyaleAPI/cr-api-ux/issues/550#issuecomment-688731490, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5DS7RRBVQYOZERUSQEBU3SEXXY7ANCNFSM4Q7FCGNQ .

smlbiobot commented 4 years ago

Re: Clan Trophy

Yes, while we could get it “at the top of the page”, that value is because we made a call to the clan endpoint. We can theoretically make additional 4 calls to fetch the correct clan war trophies for each clan, but doing so would mean that every single time someone view the war page, we have to make 6 instead fo 2 calls.

We also have a rate limit when requesting data from Supercell servers. It’s not unlimited, and we need to be conservative when it comes to doing that.

I can try to do this until they have fixed the number on their end, provided that it doesn’t break our rate limit. Reaching rate limits have dire consequences and would result in the entire site being inaccessible.

Sabbs666 commented 4 years ago

YOU are the Best! Can you give this Idea to Supercell? Maybe they will listen to You. They can give me a free unique emote for contributors for that ;) Thanks a lot, Sabbs (Leader of Polish Soldiers #2CVY8GUG)

wt., 8 wrz 2020 o 12:17 SML notifications@github.com napisał(a):

Contribution, which is the sum of boat repair and fame points, is now live.

[image: cw2-participant-contributions] https://user-images.githubusercontent.com/25040297/92464246-7465bb00-f1ff-11ea-87e5-979e3a9fb5bb.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RoyaleAPI/cr-api-ux/issues/550#issuecomment-688771276, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5DS7VFQPEUQ2WR5SIG23LSEYACLANCNFSM4Q7FCGNQ .

Sabbs666 commented 4 years ago

In such a case, not worth risking Cr-Api break-down - it's vital for Clan Leaders :)

wt., 8 wrz 2020 o 12:56 SML notifications@github.com napisał(a):

Re: Clan Trophy

Yes, while we could get it “at the top of the page”, that value is because we made a call to the clan endpoint. We can theoretically make additional 4 calls to fetch the correct clan war trophies for each clan, but doing so would mean that every single time someone view the war page, we have to make 6 instead fo 2 calls.

We also have a rate limit when requesting data from Supercell servers. It’s not unlimited, and we need to be conservative when it comes to doing that.

I can try to do this until they have fixed the number on their end, provided that it doesn’t break our rate limit. Reaching rate limits have dire consequences and would result in the entire site being inaccessible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RoyaleAPI/cr-api-ux/issues/550#issuecomment-688790509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5DS7SSLKXKMMP7E7LC2XDSEYEUHANCNFSM4Q7FCGNQ .

Sabbs666 commented 4 years ago

Hi, One more thing that came to my mind when I saw the new layout of River RAce Tab. I think the layout would be more clear if you switched the order of columns in the upper part ("Clans part"). The "Players" part is perfect! :) Then it would be REPAIR, FAME, TROPHY and we would have REPAIR, FAME, CONTRIBUTION below. I'm sure it would look and feel better - I would be more natural and logical to see Repair and Fame of Clans and Players aligned.

Best, Sabbs

wt., 8 wrz 2020 o 12:56 SML notifications@github.com napisał(a):

Re: Clan Trophy

Yes, while we could get it “at the top of the page”, that value is because we made a call to the clan endpoint. We can theoretically make additional 4 calls to fetch the correct clan war trophies for each clan, but doing so would mean that every single time someone view the war page, we have to make 6 instead fo 2 calls.

We also have a rate limit when requesting data from Supercell servers. It’s not unlimited, and we need to be conservative when it comes to doing that.

I can try to do this until they have fixed the number on their end, provided that it doesn’t break our rate limit. Reaching rate limits have dire consequences and would result in the entire site being inaccessible.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RoyaleAPI/cr-api-ux/issues/550#issuecomment-688790509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5DS7SSLKXKMMP7E7LC2XDSEYEUHANCNFSM4Q7FCGNQ .

smlbiobot commented 4 years ago

Possibly, but on mobile in fact we hide the trophy so it’s not actually aligning.

Sabbs666 commented 4 years ago

Oh - didn't know cause I always use "computer view" on my mobile when I browse CR-API :) ... but now I can see you don't hide any columns for Players' stats - there are 3 columns, so maybe don't hide Trophies as well?

Best, Sabbs

wt., 8 wrz 2020 o 15:22 SML notifications@github.com napisał(a):

Possibly, but on mobile in fact we hide the trophy so it’s not actually aligning.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RoyaleAPI/cr-api-ux/issues/550#issuecomment-688862286, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5DS7UQAOE4C7GBJAOO4C3SEYV2BANCNFSM4Q7FCGNQ .

Sabbs666 commented 4 years ago

The changes you've made are Great (both my suggestions and your other changes)! Really like it!. Is it ok if I write to you when I have some new Ideas/remarks?

Sabbs

smlbiobot commented 4 years ago

As you see, I have implemented:

This should have addressed all of your issues. Please let me know if there are any outstanding items.

Is it ok if I write to you when I have some new Ideas/remarks?

Please open a new issue if you have new ideas / feedback. Don’t add to this issue because we use these to track progress.

smlbiobot commented 3 years ago

Closing this as these should all be implemented