search

RoyaleAPI / cr-api

Clash Royale Analytics, Profiles and Insights. We no longer publish a public API. Please use the official API from Supercell.
https://RoyaleAPI.com
167 stars 20 forks source link

Pagination not working on /player/:tag/battles #342

Closed BlackHoleFox closed 6 years ago

BlackHoleFox commented 6 years ago

Request 1: https://api.royaleapi.com/player/9YU92J0VC/battles -> Line count of 13,703 Request 2: https://api.royaleapi.com/player/9YU92J0VC/battles?max=5 -> Line count of 13,703

Expected result: Only 5 battles are returned and the JSON response is significantly smaller.

Actual result: Both JSON responses are the exact same, even ending with the same battle.

Edit from fourjr: Both requests have the same amount of battles returned (25)

fourjr commented 6 years ago

Note: Pagination works as intended on /clan/:tag/battles

selfish commented 6 years ago

Fixed. Thanks This was related to #356