RoyaleAPI / cr-api

Clash Royale Analytics, Profiles and Insights. We no longer publish a public API. Please use the official API from Supercell.
https://RoyaleAPI.com
167 stars 20 forks source link

[REQUEST] Add Name and Tag fields in few endpoints #405

Closed bsantosh909 closed 6 years ago

bsantosh909 commented 6 years ago

Idea/request:

Add name and tag in endpoints like:

Request Details:

Maybe add the name and tag fields to the response in the listed endpoints above so that users wont have to make an extra call just to get the name or Tag of the player/clan.

smlbiobot commented 6 years ago

The reason that they are not there — just so you know — is because adding them would require additional requests by the server. Theoretically speaking, I can see the server potentially caching known tags + names. However, it is what is right now because assuming that the cache / db does not exist, we would be doing those requests for you.

Alpha185 commented 6 years ago

thanks, I love your website

Cordialmente,

Mauro Gyotoku +55 11 98546-1000

2018-07-05 12:19 GMT-03:00 SML notifications@github.com:

The reason that they are not there — just so you know — is because adding them would require additional requests by the server. Theoretically speaking, I can see the server potentially caching known tags + names. However, it is what is right now because assuming that the cache / db does not exist, we would be doing those requests for you.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RoyaleAPI/cr-api/issues/405#issuecomment-402758207, or mute the thread https://github.com/notifications/unsubscribe-auth/Am8yTnonQvsKXCkdp8qljFJov831hD2Pks5uDi5lgaJpZM4VEDRR .

bsantosh909 commented 6 years ago

Its completely fine if the request doesnt send those information. I made this request thinking that any request would probably send name and tag. So yeah if this is not possible the issue can be closed, but yeah I would love to hear the final words from Selfish.

fourjr commented 6 years ago

Duplicate of #297