RoyaleAPI / cr-api

Clash Royale Analytics, Profiles and Insights. We no longer publish a public API. Please use the official API from Supercell.
https://RoyaleAPI.com
167 stars 20 forks source link

[Request] Change percent calculations #406

Closed crapirobili closed 5 years ago

crapirobili commented 6 years ago

Idea/request:

  1. Briefly explain the idea or request.

    • Change the wins-, losses- and drawpercentage calculations to only use wins and losses and ignore draws and total. For instance: winsPercent = wins / (wins + losses).
  2. Briefly explain the rationale behind the request, or provide a use case.

    • The current calculations use the draw values that are derived and very much non reliable as they are mixed up with all kinds of values (like 2vs2 data). For any player not just playing 1vs1, the percentage values will be off in a non-obvious way as the naming is confusing.

It's questionable if draws should be exposed at all especially under that name), considering that they're not really draws, but at least calculations shouldn't be made on top of them.

  1. In which request/endpoint does this apply?

    • player
  2. Use the boxes at the bottom of this template to demonstrate a request and expected response.

    • N/A
Gr8z commented 6 years ago

We give you the data returned from the application. However, you can easily do these simple calculations on your own application.

selfish commented 5 years ago

While everything you wrote makes general sense, I believe people's stats rely on all of this. Can't really make changes at this stage.